drivers: pwm: Add Intel PCH blinky PWM driver #59769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanisetti
requested review from
nashif,
galak,
jhedberg,
dcpleung and
aasthagr
as code owners
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
anangl,
henrikbrixandersen,
laurenmurphyx64,
MaureenHelm and
tbursztyka
akanisetti
force-pushed
the
intel_blinky_pwm
branch
from
3b64448
to
d53dfba
Compare
akanisetti
force-pushed
the
intel_blinky_pwm
branch
from
d53dfba
to
d06a7f3
Compare
finikorg
reviewed
Jun 27, 2023
akanisetti
force-pushed
the
intel_blinky_pwm
branch
from
d06a7f3
to
8aa1940
Compare
henrikbrixandersen
requested changes
Jul 4, 2023
drivers/pwm/Kconfig.intel_blinky
Outdated
Comment on lines
14
to
15
| hex "PWM intel control register offset" | ||
| default 0x304 |
There was a problem hiding this comment.
Shouldn't this be specified in devicetree instead?
There was a problem hiding this comment.
I will move this to soc.h
There was a problem hiding this comment.
Hi @henrikbrixandersen, I have added "reg-offset" property to send it through device tree.
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| description: INTEL BLINKY PWM |
There was a problem hiding this comment.
All upper-case intended?
There was a problem hiding this comment.
No, I will change this to lower case.
Comment on lines
+15
to
+23
| clock-frequency: | ||
| type: int | ||
| required: true | ||
| description: PWM Peripheral Clock frequency in Hz |
There was a problem hiding this comment.
No need for an input clock (e.g. having a clocks property)?
There was a problem hiding this comment.
clocks is of type "phandle-array" but here I just need to mention IP frequency, so this clock frequency is needed.
akanisetti
force-pushed
the
intel_blinky_pwm
branch
3 times, most recently
from
e22e788
to
2a16587
Compare
This patch adds support for PWM blink which is found in intel's PCH hardwares. Signed-off-by: Anisetti Avinash Krishna <[email protected]>
Adds pwm node for intel raptorlake pch pwm blink IP Signed-off-by: Anisetti Avinash Krishna <[email protected]>
akanisetti
force-pushed
the
intel_blinky_pwm
branch
from
2a16587
to
4d989b9
Compare
jhedberg
previously approved these changes
Jul 12, 2023
henrikbrixandersen
previously approved these changes
Jul 12, 2023
Enable pwm api test for intel blinky on rpl_crb board. Signed-off-by: Anisetti Avinash Krishna <[email protected]>
finikorg
previously approved these changes
Jul 12, 2023
anangl
reviewed
Jul 12, 2023
akanisetti
dismissed stale reviews from finikorg, henrikbrixandersen, and jhedberg
via
4cc4e44
akanisetti
force-pushed
the
intel_blinky_pwm
branch
from
4d989b9
to
4cc4e44
Compare
akanisetti
requested review from
anangl,
jhedberg,
finikorg and
henrikbrixandersen
jhedberg
approved these changes
Jul 12, 2023
finikorg
approved these changes
Jul 12, 2023
anangl
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR for review for new PWM driver for the IP found in multiple intel PCH hardwares.
This PR includes commits for
a) The driver code
b) dts node for pwm
c) enable pwm_api test for rpl_crb
we can verify using "west build -b rpl_crb tests/drivers/pwm/pwm_api/"