Bluetooth: Controller: Remove assign to terminate_ack #59612
Conversation
mku514k
requested review from
carlescufi,
cvinayak,
thoh-ot and
kruithofa
as code owners
Assignment to conn->central.terminate_ack is not accessible after 2ada005. Remove dead code. Signed-off-by: Mateusz Kusiak <[email protected]>
mku514k
force-pushed
the
mkus-terminate-ack
branch
from
32dbc0c
to
9da52f1
Compare
| #if defined(CONFIG_BT_CENTRAL) | ||
| struct { | ||
| #if defined(CONFIG_BT_CTLR_CONN_META) | ||
| uint8_t is_must_expire:1; |
There was a problem hiding this comment.
@mtpr-ot can this be removed?
There was a problem hiding this comment.
I think we would need to remove the full "must-expire" feature first, as there are dependencies in ULL. It's used for calculating the latency.
There was a problem hiding this comment.
I don't know to what extent the feature is used by other uses/vendors, but we're not using it anymore. However, the MUST_EXPIRE feature ties into the current ticker implementation, so it may be a larger overhaul to safely remove.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Assignment to conn->central.terminate_ack is not accessible after 2ada005.
Remove dead code.
Fixes #58971