Bluetooth: BAP: Shell: Set default_stream on configured #59494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the default_stream when we initiate the configure operatio, we set it when it has succeded. In case that the codec configure fails, the stream should not really be considered configured as the default. This also ensures that the default_stream is set when using the CAP shell commands. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa,
larsgk,
MariuszSkamra and
szymon-czapracki
larsgk
approved these changes
Jun 26, 2023
MariuszSkamra
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the default_stream when we initiate the configure operatio, we set it when it has succeded.
In case that the codec configure fails, the stream should not really be considered configured as the default.
This also ensures that the default_stream is set when using the CAP shell commands.