tests: bluetooth: tester: Add commands to add and delete virtual addresses #59486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelVPV
requested review from
alwa-nordic,
jhedberg,
Vudentz and
sjanc
as code owners
PavelVPV
added a commit
to PavelVPV/auto-pts
that referenced
this pull request
Jun 21, 2023
Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878 Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address. This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests. For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address. For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it. Corresponding PR to zephyrproject-rtos: zephyrproject-rtos/zephyr#59486 Signed-off-by: Pavel Vasilyev <[email protected]>
PavelVPV
added a commit
to PavelVPV/auto-pts
that referenced
this pull request
Jun 21, 2023
Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878 Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address. This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests. For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address. For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it. Corresponding PR to zephyrproject-rtos: zephyrproject-rtos/zephyr#59486 Signed-off-by: Pavel Vasilyev <[email protected]>
m-alperen-sener
approved these changes
Jun 21, 2023
alwa-nordic
previously approved these changes
Jun 21, 2023
PavelVPV
changed the title
alxelax
previously approved these changes
Jun 26, 2023
PavelVPV
added a commit
to PavelVPV/auto-pts
that referenced
this pull request
Jun 27, 2023
Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878 Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address. This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests. For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address. For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it. Corresponding PR to zephyrproject-rtos: zephyrproject-rtos/zephyr#59486 Signed-off-by: Pavel Vasilyev <[email protected]>
mkasenberg
pushed a commit
to auto-pts/auto-pts
that referenced
this pull request
Jun 28, 2023
Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878 Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address. This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests. For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address. For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it. Corresponding PR to zephyrproject-rtos: zephyrproject-rtos/zephyr#59486 Signed-off-by: Pavel Vasilyev <[email protected]>
|
pls rebase |
PavelVPV
force-pushed
the
virt_add_fix_new_api
branch
from
835ad24
to
7c863e1
Compare
PavelVPV
force-pushed
the
virt_add_fix_new_api
branch
from
7c863e1
to
a7d3eab
Compare
alxelax
previously approved these changes
Jun 28, 2023
|
@sjanc, @alwa-nordic, @jhedberg, could you approve PR so it gets merged? Corresponding PR for auto-pts has been merged. This should fix failing PTS tests for mesh. |
alwa-nordic
previously approved these changes
Jul 3, 2023
jhedberg
previously approved these changes
Jul 3, 2023
sjanc
reviewed
Jul 3, 2023
| const struct bt_mesh_va *va; | ||
| int err; | ||
|
|
||
| if (cmd_len != sizeof(*cp)) { |
There was a problem hiding this comment.
this is not needed when expected_len is provided
| return BTP_STATUS_FAILED; | ||
| } | ||
|
|
||
| rp->addr = va->addr; |
There was a problem hiding this comment.
not sure if va->addr is host or le16, if host this should be converted
| const struct bt_mesh_va *va; | ||
| int err; | ||
|
|
||
| if (cmd_len != sizeof(*cp)) { |
There was a problem hiding this comment.
ditto: not needed if expected_len is provided
PavelVPV
dismissed stale reviews from jhedberg, alwa-nordic, and alxelax
via
0ce867f
PavelVPV
force-pushed
the
virt_add_fix_new_api
branch
from
a7d3eab
to
0ce867f
Compare
sjanc
reviewed
Jul 3, 2023
| return BTP_STATUS_FAILED; | ||
| } | ||
|
|
||
| rp->addr = sys_le16_to_cpu(va->addr); |
There was a problem hiding this comment.
shouldn't this be sys_cpu_to_le16 ? (BTP is LE)
Virtual address behavior has been changed in this PR: zephyrproject-rtos#57878 Now it is required to register virtual address before using it. Corresponding PR to auto-pts: auto-pts/auto-pts#961 Signed-off-by: Pavel Vasilyev <[email protected]>
PavelVPV
force-pushed
the
virt_add_fix_new_api
branch
from
0ce867f
to
5ca46bc
Compare
|
@sjanc , please review |
alxelax
approved these changes
Jul 7, 2023
|
@sjanc , can you please look at this PR? |
sjanc
approved these changes
Jul 25, 2023
carlescufi
approved these changes
Jul 25, 2023
m-alperen-sener
pushed a commit
to m-alperen-sener/auto-pts
that referenced
this pull request
Jul 26, 2023
Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878 Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address. This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests. For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address. For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it. Corresponding PR to zephyrproject-rtos: zephyrproject-rtos/zephyr#59486 Signed-off-by: Pavel Vasilyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual address behavior has been changed in this PR: #57878
Now it is required to register virtual address before using it.
Corresponding PR to auto-pts:
auto-pts/auto-pts#961