Bluetooth: BAP: Shell: Improve recv statistics #59386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa,
larsgk,
MariuszSkamra and
szymon-czapracki
|
We should keep track of all the places that needs to be changed for multi stream support ;) |
larsgk
previously approved these changes
Jun 27, 2023
subsys/bluetooth/audio/shell/bap.c
Outdated
| lost_pkts++; | ||
| } | ||
|
|
||
| /* TODO: Make it possible to only print every X packets, and make X settable by the shell */ |
There was a problem hiding this comment.
Sounds like a good idea to make it configurable. Also it seems like a fairly small change. Could this be added in the PR? otherwise LGTM
There was a problem hiding this comment.
I think it makes sense to add to this PR :)
Yeah, it's getting increasingly difficult :) |
Add more information when we print the recv every 100th packet, and remove all per-recv printing. This also resets all information on stream start. This does, however, no properly support multiple streams. Signed-off-by: Emil Gydesen <[email protected]>
The internval of how often we report receive stats can now be configured via the cmd_recv_stats command. Signed-off-by: Emil Gydesen <[email protected]>
larsgk
approved these changes
Jun 29, 2023
cvinayak
approved these changes
Jun 30, 2023
kruithofa
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more information when we print the recv every 100th packet, and remove all per-recv printing.
This also resets all information on stream start. This does, however, no properly support multiple streams.