Add imx3112 mux driver #59290
Add imx3112 mux driver #59290
Conversation
zephyrbot
added
area: I2C
area: I3C
platform: NXP
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
manuargue,
mmahadevan108,
teburd,
XenuIsWatching and
yvanderv
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ramiroderojas, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
|
@mfischer Can you take a look :) |
ramiroderojas
force-pushed
the
add_imx3112_mux
branch
from
5720e3a
to
96fa61b
Compare
There was a problem hiding this comment.
You may want also do what #59163 is doing where it makes sure the 2 priority configs are set right.
|
Can we get some eyes on this, this is still relevant @cfriedt :) |
I can review, but we are in feature freeze until after the release is cut. |
|
No problem, this can go on next next release, thanks @cfriedt :) |
There was a problem hiding this comment.
Hmm.. I am by no means an i3c expert. Will defer to @XenuIsWatching
This changes adds I2C support to the IMX3112 mux. That means we will need to statically choose I2C configuration during driver macrobatics, and then select the I2C write/read methods Signed-off-by: Ramiro de Rojas Perez <[email protected]>
ramiroderojas
force-pushed
the
add_imx3112_mux
branch
from
c4ee200
to
24fde4f
Compare
|
I believe I did the changes @XenuIsWatching requested, I was just waiting on him to take another look |
| static int i3c_renesas_imx3112_configure(const struct device *dev, enum i3c_config_type type, | ||
| void *config) | ||
| { | ||
| return -ENOSYS; | ||
| } | ||
|
|
||
| static int i3c_renesas_imx3112_i2c_configure(const struct device *dev, uint32_t dev_config) | ||
| { | ||
| return -ENOSYS; | ||
| } |
There was a problem hiding this comment.
I don't think thesefunctions are even needed to be defined here at all, as if they are NULL in the api struct, the api will just return -ENOSYS for you anyways
|
I only have time to skim through it right now (until I return from paternity leave a couple of weeks from now) rather than going line by line. Skimming through, I don't see how devices are initialized with a valid DA that does not conflict with anything. How is this done? |
|
Thanks @XenuIsWatching. I was trying to get in touch with the Renesas folks so they confirm that DAA is supported (or not) in the device. I'll see how much of the datasheet we can share with you :) |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
decsny
removed request for
dbaluta,
yvanderv,
mmahadevan108,
dleach02,
danieldegrasse,
DerekSnell,
EmilioCBen,
decsny,
iuliana-prodan and
manuargue
|
bot is confused by the "imx", making it think it is an NXP thing, can you please address this somehow in the maintainer yml to indicate it is a renesas device and not NXP |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Change adds driver support for I3C 2:1 mux splitter Renesas IMX3112: https://www.renesas.com/us/en/products/memory-logic/memory-interface-products/memory-multiplexers/imx3112-i3c-basic-12-bus-multiplexer
The first commit adds support for buses with I3C devices ONLY.
Second commit adds support for mixed and I2C-only buses.
Signed-off-by: Ramiro de Rojas Perez [email protected]