Bluetooth: Controller: Fix CIS failed to be established #59127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix calculation that ensured cis_offset_min_us being >= PDU_CIS_OFFSET_MIN_US. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_lazy_active_fix
branch
from
b2d06e7
to
73b9480
Compare
Thalley
requested changes
Jun 21, 2023
Fix CIS create implementation to consider CIG events with laziness before the new CIS in an already active CIG is made active. Previous laziness value of the CIG events is determined and at the CIG event where the new CIS event_count is calculated the lazy_active value determined is decremented from the total lazy value. Without this fix, event_count of the new active CIS events where incorrect, causing CIS create resulting in fail to be established. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_lazy_active_fix
branch
from
73b9480
to
db25edb
Compare
Thalley
approved these changes
Jun 29, 2023
kruithofa
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CIS create implementation to consider CIG events with laziness before the new CIS in an already active CIG is made active.
Previous laziness value of the CIG events is determined and at the CIG event where the new CIS event_count is calculated the lazy_active value determined is decremented from the total lazy value.
Without this fix, event_count of the new active CIS events where incorrect, causing CIS create resulting in fail to be established.