debug: tracing: Add Segger RTT linker section options #53569

giansta · 2023-01-06T20:17:32Z

Allows optionally placing Segger RTT data either in a specific
linker section that is located at RAM start, or in a specific linker
section defined by a memory region in DTS, as third and fourth
alternative to the DTCM section or the default data section.
This is useful to share the fixed address for different programs,
typically bootloader and application, and have seamless logging.

Signed-off-by: Giancarlo Stasi [email protected]

fixes #53544

giansta · 2023-01-06T21:05:57Z

Expected to fix #53544 with zephyrproject-rtos/segger#17 in Segger repo

microbuilder · 2023-01-10T08:07:16Z

@nordic-krch Seems OK to me, but mind having a look since you maintain the Segger integration?

giansta · 2023-01-10T09:27:41Z

@nordic-krch Seems OK to me, but mind having a look since you maintain the Segger integration?

If you mean that the approval depends on the approval of the segger PR, I totally agree :-)

zephyrbot · 2023-01-30T21:26:24Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordic-krch

Can you also update west so that it points to the changes in segger repo?

nordic-krch · 2023-03-10T08:23:40Z

drivers/debug/Kconfig.rtt

@@ -74,6 +74,9 @@ config SEGGER_RTT_SECTION_NONE
 config SEGGER_RTT_SECTION_DTCM
 	bool "Place RTT data in the DTCM linker section"

+config SEGGER_RTT_SECTION_FIXED_ADDR
+	bool "Place RTT data in specific linker section with fixed address"


don't we want default y? If bootloader is not used then it has no difference and when bootload is used then probably most users would like to get logs from bootloader and application.

Agree, done.

Maybe we could depend on the fact that we use Cortex-M here (since it's not supported by linker scripts of other architectures)?

I've added a if CPU_CORTEX_M, thanks.

nordicjm · 2024-04-17T07:16:40Z

@giansta the segger PR needs rebasing

giansta · 2024-04-17T10:28:33Z

@giansta the segger PR needs rebasing

Rebased, thanks!

nordicjm · 2024-04-25T07:54:04Z

@giansta needs rebase

nordicjm · 2024-04-25T07:55:30Z

@ioannisg @bbolen @microbuilder @povergoing @nordic-krch @MarekPieta since this is a very old PR and gets merge conflicts can you review and approve if you find it acceptable so that the module update can be merged and this is able to be merged without encountering another merge conflict?

Allows optionally placing Segger RTT data either in a specific linker section that is located at RAM start, or in a specific linker section defined by a memory region in DTS, as third and fourth alternative to the DTCM section or the default data section. This is useful to share the fixed address for different programs, typically bootloader and application, and have seamless logging. Signed-off-by: Giancarlo Stasi <[email protected]>

Use recommended write API that internally locks RTT usage and checks if the RTTcontrol block initialization is done. Signed-off-by: Giancarlo Stasi <[email protected]>

Allows RTT inizialization function to either init Cntrol Block always or initialize only after checking it it's not already initialized by another program, typically by a bootloader. Signed-off-by: Giancarlo Stasi <[email protected]>

kartben · 2024-06-12T08:32:31Z

@nordic-krch would be good to try to get this and the associated Segger PR in for 3.7?

modules/segger/Kconfig

cfriedt

Definite improvement

cfriedt · 2024-07-26T00:12:48Z

Was able to verify this working with a custom stm32 board, tests/boot/test_mcuboot

Also needed the wrapper here, which would also be a good reason to build something like this into west.

There is a PR for that.
#75508

carlescufi · 2024-08-12T08:15:14Z

@giansta thanks so much for your patience.

giansta · 2024-08-12T10:16:52Z

Thanks @carlescufi! Anyway, this PR requires even zephyrproject-rtos/segger#17
I would expect it to be merged too.

gchwier · 2024-08-14T08:45:52Z

Hi, after merging this PR not working tests:

https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/subsys/dfu/img_util

on nrf52840dk/nrf52840.
To reproduce:
${ZEPHYR_BASE}/scripts/twister -p nrf52840dk/nrf52840 -T ${ZEPHYR_BASE}/tests/subsys/dfu/img_util -s dfu.image_util --west-flash --device-testing --device-serial /dev/ttyACM0 -c -vv
output:

DEBUG   - DEVICE: Running TESTSUITE img_util
DEBUG   - DEVICE: ===================================================================
DEBUG   - DEVICE: START - test_check_flash
DEBUG   - DEVICE: ASSERTION FAIL [0] @ WEST_TOPDIR/zephyr/lib/utils/onoff.c:283
DEBUG   - DEVICE: E: r0/a1:  0x00000004  r1/a2:  0x0000011b  r2/a3:  0x00000001
DEBUG   - DEVICE: E: r3/a4:  0x00000004 r12/ip:  0x00000040 r14/lr:  0x00000871
DEBUG   - DEVICE: E:  xpsr:  0x21000000
DEBUG   - DEVICE: E: Faulting instruction address (r15/pc): 0x000074d0
DEBUG   - DEVICE: E: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
DEBUG   - DEVICE: E: Current thread: 0 (unknown)
DEBUG   - DEVICE: E: Halting system
DEBUG   - Timed out while monitoring

bisect shows that commit: 711ed08

Edit: added issue #77058

kartben · 2024-08-14T08:56:49Z

@gchwier I think it might be because zephyrproject-rtos/segger#17 still hasn't been merged? cc @carlescufi

gchwier · 2024-08-14T10:26:25Z

@kartben I've used that PR and looks that it does not help, still the same issue.

giansta requested review from MaureenHelm, galak and ioannisg as code owners January 6, 2023 20:17

zephyrbot added the area: ARM ARM (32-bit) Architecture label Jan 6, 2023

zephyrbot requested review from bbolen, carlocaione, microbuilder, povergoing and stephanosio January 6, 2023 20:18

zephyrbot assigned microbuilder Jan 6, 2023

giansta force-pushed the fix/rtt-cb-common-addr branch from 5bc4d75 to 1ed0a56 Compare January 6, 2023 20:40

giansta mentioned this pull request Jan 6, 2023

Segger RTT: support CONFIG_SEGGER_RTT_INIT_MODE and optimizations zephyrproject-rtos/segger#17

Open

giansta mentioned this pull request Jan 6, 2023

Cannot see both bootloader and application RTT output #53544

Closed

giansta force-pushed the fix/rtt-cb-common-addr branch from 1ed0a56 to f16648e Compare January 9, 2023 21:23

microbuilder assigned nordic-krch and unassigned microbuilder Jan 10, 2023

giansta force-pushed the fix/rtt-cb-common-addr branch from f16648e to dc86be9 Compare January 30, 2023 21:25

giansta requested a review from nashif as a code owner January 30, 2023 21:25

zephyrbot added manifest manifest-segger labels Jan 30, 2023

giansta force-pushed the fix/rtt-cb-common-addr branch 2 times, most recently from 32093e9 to 9c52b9e Compare January 31, 2023 09:59

giansta force-pushed the fix/rtt-cb-common-addr branch from 9c52b9e to 59be1f1 Compare February 20, 2023 20:42

nordicjm self-requested a review March 9, 2023 16:15

nordic-krch reviewed Mar 10, 2023

View reviewed changes

giansta force-pushed the fix/rtt-cb-common-addr branch from 59be1f1 to c2e9d2d Compare March 10, 2023 21:49

zephyrbot removed the manifest-segger label Feb 21, 2024

github-actions bot removed the Stale label Feb 22, 2024

nordicjm requested review from carlocaione, sigvartmh, MarekPieta and carlescufi April 17, 2024 10:30

sigvartmh approved these changes Apr 17, 2024

View reviewed changes

giansta added 3 commits April 25, 2024 14:13

drivers: console: rtt_console: use Segger recommended write API

b72cf05

Use recommended write API that internally locks RTT usage and checks if the RTTcontrol block initialization is done. Signed-off-by: Giancarlo Stasi <[email protected]>

giansta force-pushed the fix/rtt-cb-common-addr branch from a876d07 to 42f1b2c Compare April 25, 2024 12:25

ithinuel reviewed Jun 17, 2024

View reviewed changes

modules/segger/Kconfig Show resolved Hide resolved

cfriedt approved these changes Jul 24, 2024

View reviewed changes

nordicjm requested a review from ithinuel July 24, 2024 06:14

ithinuel approved these changes Jul 24, 2024

View reviewed changes

nordic-krch approved these changes Aug 12, 2024

View reviewed changes

nordicjm approved these changes Aug 12, 2024

View reviewed changes

carlescufi approved these changes Aug 12, 2024

View reviewed changes

carlescufi merged commit 19c67d5 into zephyrproject-rtos:main Aug 12, 2024
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

debug: tracing: Add Segger RTT linker section options #53569

debug: tracing: Add Segger RTT linker section options #53569

giansta commented Jan 6, 2023 •

edited

Loading

giansta commented Jan 6, 2023

microbuilder commented Jan 10, 2023

giansta commented Jan 10, 2023

zephyrbot commented Jan 30, 2023 •

edited

Loading

nordic-krch left a comment

nordic-krch Mar 10, 2023

giansta Mar 10, 2023

MarekPieta May 23, 2023

giansta Sep 21, 2023

nordicjm commented Apr 17, 2024

giansta commented Apr 17, 2024

nordicjm commented Apr 25, 2024

nordicjm commented Apr 25, 2024

kartben commented Jun 12, 2024

cfriedt left a comment

cfriedt commented Jul 26, 2024 •

edited

Loading

carlescufi commented Aug 12, 2024

giansta commented Aug 12, 2024

gchwier commented Aug 14, 2024 •

edited

Loading

kartben commented Aug 14, 2024

gchwier commented Aug 14, 2024

debug: tracing: Add Segger RTT linker section options #53569

debug: tracing: Add Segger RTT linker section options #53569

Conversation

giansta commented Jan 6, 2023 • edited Loading

giansta commented Jan 6, 2023

microbuilder commented Jan 10, 2023

giansta commented Jan 10, 2023

zephyrbot commented Jan 30, 2023 • edited Loading

nordic-krch left a comment

Choose a reason for hiding this comment

nordic-krch Mar 10, 2023

Choose a reason for hiding this comment

giansta Mar 10, 2023

Choose a reason for hiding this comment

MarekPieta May 23, 2023

Choose a reason for hiding this comment

giansta Sep 21, 2023

Choose a reason for hiding this comment

nordicjm commented Apr 17, 2024

giansta commented Apr 17, 2024

nordicjm commented Apr 25, 2024

nordicjm commented Apr 25, 2024

kartben commented Jun 12, 2024

cfriedt left a comment

Choose a reason for hiding this comment

cfriedt commented Jul 26, 2024 • edited Loading

carlescufi commented Aug 12, 2024

giansta commented Aug 12, 2024

gchwier commented Aug 14, 2024 • edited Loading

kartben commented Aug 14, 2024

gchwier commented Aug 14, 2024

giansta commented Jan 6, 2023 •

edited

Loading

zephyrbot commented Jan 30, 2023 •

edited

Loading

cfriedt commented Jul 26, 2024 •

edited

Loading

gchwier commented Aug 14, 2024 •

edited

Loading