Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/soc: comply to coding guidelines MISRA C:2012 Rule 14.4 #48080

Conversation

simhein
Copy link
Collaborator

@simhein simhein commented Jul 20, 2022

Fix coding guideline MISRA C:2012 Rule 14.4 in boards and soc:

The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.

This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main

The commit in this PR is a subset of the original auditable-branch commit:
5d02614

MISRA C:2012 Rule 14.4 (The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.)

Use `do { ... } while (false)' instead of `do { ... } while (0)'.

This commit is a subset of the original commit:
5d02614

Signed-off-by: Simon Hein <[email protected]>
MISRA C:2012 Rule 14.4 (The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.)

Use `do { ... } while (false)' instead of `do { ... } while (0)'.

This commit is a subset of the original commit:
5d02614

Signed-off-by: Simon Hein <[email protected]>
@aescolar aescolar merged commit c29d0a3 into zephyrproject-rtos:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Coding Guidelines Coding guidelines and style area: MISRA-C area: native port Host native arch port (native_sim) platform: nRFx BSIM nrf5x_bsim platform: Nuvoton NPCX Nuvoton NPCX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants