arch: comply to coding guidelines MISRA C:2012 Rule 14.4 #48065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MISRA C:2012 Rule 14.4 (The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.)
Use `do { ... } while (false)' instead of `do { ... } while (0)'.
Use comparisons with zero instead of implicitly testing integers.
Use comparisons with NULL instead of implicitly testing pointers.
Use comparisons with NUL instead of implicitly testing plain chars.
This commit is a subset of the original auditable-branch commit:
5d02614
Signed-off-by: Simon Hein <[email protected]>
simhein
requested review from
nashif,
jhedberg,
aasthagr,
MaureenHelm,
galak and
ioannisg
as code owners
zephyrbot
added
area: ARM
zephyrbot
requested review from
andyross,
bbolen,
carlocaione,
ceolin,
dcpleung,
enjiamai,
laurenmurphyx64,
microbuilder,
povergoing and
stephanosio
and removed request for
aasthagr
simhein
added
area: MISRA-C
area: Coding Guidelines
simhein
added
area: ARM
dcpleung
approved these changes
Jul 20, 2022
carlocaione
approved these changes
Jul 20, 2022
enjiamai
approved these changes
Jul 20, 2022
stephanosio
approved these changes
Jul 20, 2022
microbuilder
approved these changes
Jul 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix coding guideline MISRA C:2012 Rule 14.4 in arch:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
5d02614