Skip to content

Commit

Permalink
posix: sys: sysconf: Unconditionally define POSIX macros
Browse files Browse the repository at this point in the history
The POSIX macros ATEXIT_MAX, PAGE_SIZE, and PAGESIZE (queriable through
sysconf()) were conditionally defined only if an existing definition
did not already exist. These should be defined unconditionally in their
header to ensure they get the correct values.

If these macros are defined elsewhere with a different meaning, that's a
problem. There was an issue where PAGESIZE was already defined with a
different meaning. See #74623 and #74428.

This commit defines ATEXIT_MAX, PAGE_SIZE, and PAGESIZE unconditionally.

Signed-off-by: Ben Marsh <[email protected]>
  • Loading branch information
besmarsh committed Jun 25, 2024
1 parent 2437832 commit dc56251
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions include/zephyr/posix/posix_features.h
Original file line number Diff line number Diff line change
Expand Up @@ -310,17 +310,10 @@
#define MQ_OPEN_MAX _POSIX_MQ_OPEN_MAX
#define MQ_PRIO_MAX _POSIX_MQ_PRIO_MAX

#ifndef ATEXIT_MAX
#define ATEXIT_MAX 8
#endif

#ifndef PAGE_SIZE
#define PAGE_SIZE CONFIG_POSIX_PAGE_SIZE
#endif

#ifndef PAGESIZE
#define PAGESIZE PAGE_SIZE
#endif

#define PTHREAD_DESTRUCTOR_ITERATIONS _POSIX_THREAD_DESTRUCTOR_ITERATIONS
#define PTHREAD_KEYS_MAX _POSIX_THREAD_KEYS_MAX
Expand Down

0 comments on commit dc56251

Please sign in to comment.