drivers: regulator: Fixed reference counting during enable

Reference counting was broken when adding the enable delay. Now reverted to previous pattern. Signed-off-by: Andy Sinclair <[email protected]>
zephyrproject-rtos · Nov 23, 2023 · c3a54ae · c3a54ae
1 parent 64cce48
commit c3a54ae
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/drivers/regulator/regulator_common.c b/drivers/regulator/regulator_common.c
@@ -107,10 +107,13 @@ int regulator_enable(const struct device *dev)
 	(void)k_mutex_lock(&data->lock, K_FOREVER);
 #endif
 
-	if (data->refcnt == 0) {
+	data->refcnt++;
+
+	if (data->refcnt == 1) {
 		ret = api->enable(dev);
-		if (ret == 0) {
-			data->refcnt++;
+		if (ret < 0) {
+			data->refcnt--;
+		} else {
 			regulator_delay(config->off_on_delay_us);
 		}
 	}