Skip to content

Commit

Permalink
Bluetooth: Host: Remove conn param update checks
Browse files Browse the repository at this point in the history
The rationale behind that change is that the Application can use the
`bt_conn_le_param_update()` API to signal the controller to reschedule
the link.

Even if the new connection params are within the old ones, the
controller would be free to choose an e.g. smaller interval. The host
API should not prevent this usage.

Fixes #74292

Co-authored-by: Knut Eldhuset <[email protected]>
Signed-off-by: Jonathan Rico <[email protected]>
  • Loading branch information
2 people authored and nashif committed Jul 4, 2024
1 parent 2afc6f0 commit ac37d64
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions subsys/bluetooth/host/conn.c
Original file line number Diff line number Diff line change
Expand Up @@ -3034,15 +3034,6 @@ int bt_conn_le_param_update(struct bt_conn *conn,
LOG_DBG("conn %p features 0x%02x params (%d-%d %d %d)", conn, conn->le.features[0],
param->interval_min, param->interval_max, param->latency, param->timeout);

/* Check if there's a need to update conn params */
if (conn->le.interval >= param->interval_min &&
conn->le.interval <= param->interval_max &&
conn->le.latency == param->latency &&
conn->le.timeout == param->timeout) {
atomic_clear_bit(conn->flags, BT_CONN_PERIPHERAL_PARAM_SET);
return -EALREADY;
}

if (IS_ENABLED(CONFIG_BT_CENTRAL) &&
conn->role == BT_CONN_ROLE_CENTRAL) {
return send_conn_le_param_update(conn, param);
Expand Down

0 comments on commit ac37d64

Please sign in to comment.