settings: shell: Fix possible buffer overflow

Checks the size of the given string before copying it to internal buffer. Signed-off-by: Flavio Ceolin <[email protected]>
zephyrproject-rtos · Dec 15, 2023 · 8977784 · 8977784
1 parent e70a1a0
commit 8977784
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/subsys/settings/src/settings_shell.c b/subsys/settings/src/settings_shell.c
@@ -182,6 +182,11 @@ static int cmd_write(const struct shell *shell_ptr, size_t argc, char *argv[])
 		break;
 	case SETTINGS_VALUE_STRING:
 		buffer_len = strlen(argv[argc - 1]) + 1;
+		if (buffer_len > sizeof(buffer)) {
+			shell_error(shell_ptr, "%s is bigger than shell's buffer", argv[argc - 1]);
+			return -EINVAL;
+		}
+
 		memcpy(buffer, argv[argc - 1], buffer_len);
 		break;
 	}