Process completed with exit code 2.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const File:drivers/comparator/comparator_shell.c Line:18

Process completed with exit code 1.

drivers/comparator/comparator_shell.c:18 static const char * array should probably be static const char * const

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define MCUX_ACMP_ENUM(name, value) \ - _CONCAT_4(COMP_MCUX_ACMP_, name, _, value) - -#define MCUX_ACMP_DT_INST_ENUM(inst, name, prop) \ +#define MCUX_ACMP_ENUM(name, value) _CONCAT_4(COMP_MCUX_ACMP_, name, _, value) + +#define MCUX_ACMP_DT_INST_ENUM(inst, name, prop) \ MCUX_ACMP_ENUM(name, DT_INST_STRING_TOKEN(inst, prop)) -#define MCUX_ACMP_DT_INST_ENUM_OR(inst, name, prop, or) \ - COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, prop), \ - (MCUX_ACMP_DT_INST_ENUM(inst, name, prop)), \ +#define MCUX_ACMP_DT_INST_ENUM_OR(inst, name, prop, or) \ + COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, prop), (MCUX_ACMP_DT_INST_ENUM(inst, name, prop)), \ (MCUX_ACMP_ENUM(name, or))) -#define MCUX_ACMP_DT_INST_OFFSET_MODE(inst) \ +#define MCUX_ACMP_DT_INST_OFFSET_MODE(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, OFFSET_MODE, offset_mode, LEVEL0) -#define MCUX_ACMP_DT_INST_HYST_MODE(inst) \ +#define MCUX_ACMP_DT_INST_HYST_MODE(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, HYSTERESIS_MODE, hysteresis_mode, LEVEL0) -#define MCUX_ACMP_DT_INST_EN_HS_MODE(inst) \ - DT_INST_PROP(inst, enable_high_speed_mode) - -#define MCUX_ACMP_DT_INST_INV_OUT(inst) \ - DT_INST_PROP(inst, invert_output) - -#define MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst) \ - DT_INST_PROP(inst, use_unfiltered_output) - -#define MCUX_ACMP_DT_INST_EN_PIN_OUT(inst) \ - DT_INST_PROP(inst, enable_pin_out) - -#define MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst) \ - { \ - .offset_mode = MCUX_ACMP_DT_INST_OFFSET_MODE(inst), \ - .hysteresis_mode = MCUX_ACMP_DT_INST_HYST_MODE(inst), \ - .enable_high_speed_mode = MCUX_ACMP_DT_INST_EN_HS_MODE(inst), \ - .invert_output = MCUX_ACMP_DT_INST_INV_OUT(inst), \ - .use_unfiltered_output = MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst), \ - .enable_pin_output = MCUX_ACMP_DT_INST_EN_PIN_OUT(inst), \ - } - -#define MCUX_ACMP_DT_INST_P_MUX_IN(inst) \ - MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, positive_mux_input) - -#define MCUX_ACMP_DT_INST_N_MUX_IN(inst) \ - MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, negative_mux_input) - -#define MCUX_ACMP_DT_INST_P_PORT_IN(inst) \ +#define MCUX_ACMP_DT_INST_EN_HS_MODE(inst) DT_INST_PROP(inst, enable_high_speed_mode) + +#define MCUX_ACMP_DT_INST_INV_OUT(inst) DT_INST_PROP(inst, invert_output) + +#define MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst) DT_INST_PROP(inst, use_unfiltered_output) + +#define MCUX_ACMP_DT_INST_EN_PIN_OUT(inst) DT_INST_PROP(inst, enable_pin_out) + +#define MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst) \ + { \ + .offset_mode = MCUX_ACMP_DT_INST_OFFSET_MODE(inst), \ + .hysteresis_mode = MCUX_ACMP_DT_INST_HYST_MODE(inst), \ + .enable_high_speed_mode = MCUX_ACMP_DT_INST_EN_HS_MODE(inst), \ + .invert_output = MCUX_ACMP_DT_INST_INV_OUT(inst), \ + .use_unfiltered_output = MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst), \ + .enable_pin_output = MCUX_ACMP_DT_INST_EN_PIN_OUT(inst), \ + } + +#define MCUX_ACMP_DT_INST_P_MUX_IN(inst) MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, positive_mux_input) + +#define MCUX_ACMP_DT_INST_N_MUX_IN(inst) MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, negative_mux_input) + +#define MCUX_ACMP_DT_INST_P_PORT_IN(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, PORT_INPUT, positive_port_input, MUX) -#define MCUX_ACMP_DT_INST_N_PORT_IN(inst) \ +#define MCUX_ACMP_DT_INST_N_PORT_IN(inst) \ MCUX_ACMP_DT_I

drivers/comparator/comparator_mcux_acmp.c:187 -#define MCUX_ACMP_ENUM(name, value) \ - _CONCAT_4(COMP_MCUX_ACMP_, name, _, value) - -#define MCUX_ACMP_DT_INST_ENUM(inst, name, prop) \ +#define MCUX_ACMP_ENUM(name, value) _CONCAT_4(COMP_MCUX_ACMP_, name, _, value) + +#define MCUX_ACMP_DT_INST_ENUM(inst, name, prop) \ MCUX_ACMP_ENUM(name, DT_INST_STRING_TOKEN(inst, prop)) -#define MCUX_ACMP_DT_INST_ENUM_OR(inst, name, prop, or) \ - COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, prop), \ - (MCUX_ACMP_DT_INST_ENUM(inst, name, prop)), \ +#define MCUX_ACMP_DT_INST_ENUM_OR(inst, name, prop, or) \ + COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, prop), (MCUX_ACMP_DT_INST_ENUM(inst, name, prop)), \ (MCUX_ACMP_ENUM(name, or))) -#define MCUX_ACMP_DT_INST_OFFSET_MODE(inst) \ +#define MCUX_ACMP_DT_INST_OFFSET_MODE(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, OFFSET_MODE, offset_mode, LEVEL0) -#define MCUX_ACMP_DT_INST_HYST_MODE(inst) \ +#define MCUX_ACMP_DT_INST_HYST_MODE(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, HYSTERESIS_MODE, hysteresis_mode, LEVEL0) -#define MCUX_ACMP_DT_INST_EN_HS_MODE(inst) \ - DT_INST_PROP(inst, enable_high_speed_mode) - -#define MCUX_ACMP_DT_INST_INV_OUT(inst) \ - DT_INST_PROP(inst, invert_output) - -#define MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst) \ - DT_INST_PROP(inst, use_unfiltered_output) - -#define MCUX_ACMP_DT_INST_EN_PIN_OUT(inst) \ - DT_INST_PROP(inst, enable_pin_out) - -#define MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst) \ - { \ - .offset_mode = MCUX_ACMP_DT_INST_OFFSET_MODE(inst), \ - .hysteresis_mode = MCUX_ACMP_DT_INST_HYST_MODE(inst), \ - .enable_high_speed_mode = MCUX_ACMP_DT_INST_EN_HS_MODE(inst), \ - .invert_output = MCUX_ACMP_DT_INST_INV_OUT(inst), \ - .use_unfiltered_output = MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst), \ - .enable_pin_output = MCUX_ACMP_DT_INST_EN_PIN_OUT(inst), \ - } - -#define MCUX_ACMP_DT_INST_P_MUX_IN(inst) \ - MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, positive_mux_input) - -#define MCUX_ACMP_DT_INST_N_MUX_IN(inst) \ - MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, negative_mux_input) - -#define MCUX_ACMP_DT_INST_P_PORT_IN(inst) \ +#define MCUX_ACMP_DT_INST_EN_HS_MODE(inst) DT_INST_PROP(inst, enable_high_speed_mode) + +#define MCUX_ACMP_DT_INST_INV_OUT(inst) DT_INST_PROP(inst, invert_output) + +#define MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst) DT_INST_PROP(inst, use_unfiltered_output) + +#define MCUX_ACMP_DT_INST_EN_PIN_OUT(inst) DT_INST_PROP(inst, enable_pin_out) + +#define MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst) \ + { \ + .offset_mode = MCUX_ACMP_DT_INST_OFFSET_MODE(inst), \ + .hysteresis_mode = MCUX_ACMP_DT_INST_HYST_MODE(inst), \ + .enable_high_speed_mode = MCUX_ACMP_DT_INST_EN_HS_MODE(inst), \ + .invert_output = MCUX_ACMP_DT_INST_INV_OUT(inst), \ + .use_unfiltered_output = MCUX_ACMP_DT_INST_USE_UNFILTERED_OUT(inst), \ + .enable_pin_output = MCUX_ACMP_DT_INST_EN_PIN_OUT(inst), \ + } + +#define MCUX_ACMP_DT_INST_P_MUX_IN(inst) MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, positive_mux_input) + +#define MCUX_ACMP_DT_INST_N_MUX_IN(inst) MCUX_ACMP_DT_INST_ENUM(inst, MUX_INPUT, negative_mux_input) + +#define MCUX_ACMP_DT_INST_P_PORT_IN(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, PORT_INPUT, positive_port_input, MUX) -#define MCUX_ACMP_DT_INST_N_PORT_IN(inst) \ +#define MCUX_ACMP_DT_INST_N_PORT_IN(inst) \ MCUX_ACMP_DT_INST_ENUM_OR(inst, PORT_INPUT, negative_port_input, MUX) -#define MCUX_ACMP_DT_INST_INPUT_CONFIG_INIT(i

drivers/comparator/comparator_mcux_acmp.c:278 -static int mcux_acmp_set_trigger(const struct device *dev, - enum comparator_trigger trigger) +static int mcux_acmp_set_trigger(const struct device *dev, enum comparator_trigger trigger)

drivers/comparator/comparator_mcux_acmp.c:300 - data->interrupt_mask = kACMP_OutputFallingInterruptEnable | - kACMP_OutputRisingInterruptEnable; + data->interrupt_mask = + kACMP_OutputFallingInterruptEnable | kACMP_OutputRisingInterruptEnable;

drivers/comparator/comparator_mcux_acmp.c:312 -static int mcux_acmp_set_trigger_callback(const struct device *dev, - comparator_callback_t callback, +static int mcux_acmp_set_trigger_callback(const struct device *dev, comparator_callback_t callback,

drivers/comparator/comparator_mcux_acmp.c:461 - acmp_dac_config.workMode = config->enable_high_speed_mode - ? kACMP_DACWorkHighSpeedMode - : kACMP_DACWorkLowSpeedMode; + acmp_dac_config.workMode = config->enable_high_speed_mode ? kACMP_DACWorkHighSpeedMode + : kACMP_DACWorkLowSpeedMode;

drivers/comparator/comparator_mcux_acmp.c:602 -#define MCUX_ACMP_IRQ_HANDLER_SYM(inst) \ - _CONCAT(mcux_acmp_irq_init, inst) - -#define MCUX_ACMP_IRQ_HANDLER_DEFINE(inst) \ - static void MCUX_ACMP_IRQ_HANDLER_SYM(inst)(void) \ - { \ - IRQ_CONNECT(DT_INST_IRQN(inst), \ - DT_INST_IRQ(inst, priority), \ - mcux_acmp_irq_handler, \ - DEVICE_DT_INST_GET(inst), \ - 0); \ - \ - irq_enable(DT_INST_IRQN(inst)); \ - } - -#define MCUX_ACMP_DEVICE(inst) \ - PINCTRL_DT_INST_DEFINE(inst); \ - \ - static struct mcux_acmp_data _CONCAT(data, inst); \ - \ - MCUX_ACMP_IRQ_HANDLER_DEFINE(inst) \ - \ - static const struct mcux_acmp_config _CONCAT(config, inst) = { \ - .base = (CMP_Type *)DT_INST_REG_ADDR(inst), \ - .pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(inst), \ - .irq_init = MCUX_ACMP_IRQ_HANDLER_SYM(inst), \ - .mode_config = MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst), \ - .input_config = MCUX_ACMP_DT_INST_INPUT_CONFIG_INIT(inst), \ - .filter_config = MCUX_ACMP_DT_INST_FILTER_CONFIG_INIT(inst), \ - .dac_config = MCUX_ACMP_DT_INST_DAC_CONFIG_INIT(inst), \ - IF_ENABLED(COMP_MCUX_ACMP_HAS_DISCRETE_MODE, \ - (.dm_config = MCUX_ACMP_DT_INST_DM_CONFIG_INIT(inst),)) \ - }; \ - \ - PM_DEVICE_DT_INST_DEFINE(inst, mcux_acmp_pm_callback); \ - \ - DEVICE_DT_INST_DEFINE(inst, \ - mcux_acmp_init, \ - PM_DEVICE_DT_INST_GET(inst), \ - &_CONCAT(data, inst), \ - &_CONCAT(config, inst), \ - POST_KERNEL, \ - CONFIG_COMPARATOR_INIT_PRIORITY, \ - &mcux_acmp_comp_api); +#define MCUX_ACMP_IRQ_HANDLER_SYM(inst) _CONCAT(mcux_acmp_irq_init, inst) + +#define MCUX_ACMP_IRQ_HANDLER_DEFINE(inst) \ + static void MCUX_ACMP_IRQ_HANDLER_SYM(inst)(void) \ + { \ + IRQ_CONNECT(DT_INST_IRQN(inst), DT_INST_IRQ(inst, priority), \ + mcux_acmp_irq_handler, DEVICE_DT_INST_GET(inst), 0); \ + \ + irq_enable(DT_INST_IRQN(inst)); \ + } + +#define MCUX_ACMP_DEVICE(inst) \ + PINCTRL_DT_INST_DEFINE(inst); \ + \ + static struct mcux_acmp_data _CONCAT(data, inst); \ + \ + MCUX_ACMP_IRQ_HANDLER_DEFINE(inst) \ + \ + static const struct mcux_acmp_config _CONCAT(config, inst) = { \ + .base = (CMP_Type *)DT_INST_REG_ADDR(inst), \ + .pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(inst), \ + .irq_init = MCUX_ACMP_IRQ_HANDLER_SYM(inst), \ + .mode_config = MCUX_ACMP_DT_INST_MODE_CONFIG_INIT(inst), \ + .input_config = MCUX_ACMP_DT_INST_INPUT_CONFIG_INIT(inst), \ + .filter_config = MCUX_ACMP_DT_INST_FILTER_CONFIG_INIT(inst), \ + .dac_config = MCUX_ACMP_DT_INST_DAC_CONFIG_INIT(inst), \ + IF_ENABLED(COMP_MCUX_ACMP_HAS_DISCRETE_MODE, \ + (.dm_config = MCUX_ACMP_DT_INST_DM_CONFIG_INIT(inst), ))}; \ +

drivers/comparator/comparator_nrf_comp.c:40 -#define SHIM_NRF_COMP_DT_INST_REF_SEL(inst) \ +#define SHIM_NRF_COMP_DT_INST_REF_SEL(inst) \ _CONCAT(NRF_COMP_REF_, DT_INST_STRING_TOKEN(inst, reference_selection)) -#define SHIM_NRF_COMP_DT_INST_EXT_REF(inst) \ +#define SHIM_NRF_COMP_DT_INST_EXT_REF(inst) \ _CONCAT(NRF_COMP_, DT_INST_STRING_TOKEN(inst, external_reference)) -#define SHIM_NRF_COMP_DT_INST_MAIN_MODE_IS_SE(inst) \ - DT_INST_ENUM_HAS_VALUE(inst, main_mode, SE) - -#define SHIM_NRF_COMP_DT_INST_TH_DOWN(inst) \ - DT_INST_PROP(inst, threshold_down) - -#define SHIM_NRF_COMP_DT_INST_TH_UP(inst) \ - DT_INST_PROP(inst, threshold_up) - -#define SHIM_NRF_COMP_DT_INST_SPEED_MODE(inst) \ +#define SHIM_NRF_COMP_DT_INST_MAIN_MODE_IS_SE(inst) DT_INST_ENUM_HAS_VALUE(inst, main_mode, SE) + +#define SHIM_NRF_COMP_DT_INST_TH_DOWN(inst) DT_INST_PROP(inst, threshold_down) + +#define SHIM_NRF_COMP_DT_INST_TH_UP(inst) DT_INST_PROP(inst, threshold_up) + +#define SHIM_NRF_COMP_DT_INST_SPEED_MODE(inst) \ _CONCAT(NRF_COMP_SP_MODE_, DT_INST_STRING_TOKEN(inst, speed_mode)) -#define SHIM_NRF_COMP_DT_INST_HYST(inst) \ +#define SHIM_NRF_COMP_DT_INST_HYST(inst) \ _CONCAT(NRF_COMP_HYST_, DT_INST_STRING_TOKEN(inst, hysteresis)) -#define SHIM_NRF_COMP_DT_INST_ISOURCE(inst) \ +#define SHIM_NRF_COMP_DT_INST_ISOURCE(inst) \ _CONCAT(NRF_COMP_ISOURCE_, DT_INST_STRING_TOKEN(inst, isource)) -#define SHIM_NRF_COMP_DT_INST_POS_INPUT(inst) \ +#define SHIM_NRF_COMP_DT_INST_POS_INPUT(inst) \

drivers/comparator/comparator_nrf_comp.c:135 -static int shim_nrf_comp_input_to_nrf(enum comp_nrf_comp_input shim, - nrf_comp_input_t *nrf) +static int shim_nrf_comp_input_to_nrf(enum comp_nrf_comp_input shim, nrf_comp_input_t *nrf)

drivers/comparator/comparator_nrf_comp.c:201 - nrf_comp_sp_mode_t *nrf) + nrf_comp_sp_mode_t *nrf)