ADIN2111 OA mode fixes #146816
Annotations
12 errors, 1 warning, and 3 notices
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L361
drivers/ethernet/eth_adin2111.c:361 trailing whitespace
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L363
drivers/ethernet/eth_adin2111.c:363 do not use C99 // comments
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L369
drivers/ethernet/eth_adin2111.c:369 do not use C99 // comments
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L719
drivers/ethernet/eth_adin2111.c:719 else should follow close brace '}'
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L727
drivers/ethernet/eth_adin2111.c:727 trailing whitespace
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L733
drivers/ethernet/eth_adin2111.c:733 else should follow close brace '}'
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L736
drivers/ethernet/eth_adin2111.c:736 trailing whitespace
|
Run Compliance Tests
Process completed with exit code 4.
|
check-warns:
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 7625880d34:
1: UC5 Commit title exceeds max length (84>75): "drivers: ethernet: adin2111: Proper calculation of EBO in eth_adin2111_send_oa_frame"
3: UC4 Commit message body line exceeds max length (113>75): "Calculate the EBO correctly, so the total frame written to TX FIFO does not exceed maximum Ethernet frame length."
4: UC4 Commit message body line exceeds max length (161>75): "Makes the TCP stack to work properly, otherwise packets > 1472 are dopped, as they would be padded by 64 more bytes and hence exceed maximum Ethernet frame size."
Commit 6ead73dbc3:
3: UC4 Commit message body line exceeds max length (198>75): "Fixes a bug where eth_adin2111_oa_data_read returning error (for example when the is not enough RX buffers available) would exit the thread and cause RTOS crash as the thread is set up as essential."
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
7625880d34ee6040b38f100a9bd4ab7364c66660: drivers/ethernet/eth_adin2111.c:361: trailing whitespace.
6ead73dbc3f757ccba235a15ea522a2e84612576: drivers/ethernet/eth_adin2111.c:716: trailing whitespace.
6ead73dbc3f757ccba235a15ea522a2e84612576: drivers/ethernet/eth_adin2111.c:725: trailing whitespace.
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
TRAILING_WHITESPACE: trailing whitespace
File:drivers/ethernet/eth_adin2111.c
Line:361
C99_COMMENTS: do not use C99 // comments
File:drivers/ethernet/eth_adin2111.c
Line:363
C99_COMMENTS: do not use C99 // comments
File:drivers/ethernet/eth_adin2111.c
Line:369
ELSE_AFTER_BRACE: else should follow close brace '}'
File:drivers/ethernet/eth_adin2111.c
Line:719
TRAILING_WHITESPACE: trailing whitespace
File:drivers/ethernet/eth_adin2111.c
Line:727
ELSE_AFTER_BRACE: else should follow close brace '}'
File:drivers/ethernet/eth_adin2111.c
Line:733
TRAILING_WHITESPACE: trailing whitespace
File:drivers/ethernet/eth_adin2111.c
Line:736
|
check-warns
Process completed with exit code 1.
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-
+
if (chunks > 1) {
- //we have to calculate EBO so we do not exceed maximum Ethernet frame length
+ // we have to calculate EBO so we do not exceed maximum Ethernet frame length
ebo = (len % ctx->oa_cps) - 1;
if (ebo < 0) {
ebo += ctx->oa_cps;
}
} else {
- //we have to pad to the minimum Ethernet frame length
+ // we have to pad to the minimum Ethernet frame length
File:drivers/ethernet/eth_adin2111.c
Line:370
You may want to run clang-format on this change:
- }
- else {
+ } else {
File:drivers/ethernet/eth_adin2111.c
Line:720
You may want to run clang-format on this change:
-
+
/* handle port 2 rx */
if ((status1 & ADIN2111_STATUS1_P2_RX_RDY) && is_adin2111) {
if (ctx->oa) {
ret = eth_adin2111_oa_data_read(dev, 1);
- }
- else {
+ } else {
ret = adin2111_read_fifo(dev, 1U);
}
-
+
File:drivers/ethernet/eth_adin2111.c
Line:737
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L370
drivers/ethernet/eth_adin2111.c:370
-
+
if (chunks > 1) {
- //we have to calculate EBO so we do not exceed maximum Ethernet frame length
+ // we have to calculate EBO so we do not exceed maximum Ethernet frame length
ebo = (len % ctx->oa_cps) - 1;
if (ebo < 0) {
ebo += ctx->oa_cps;
}
} else {
- //we have to pad to the minimum Ethernet frame length
+ // we have to pad to the minimum Ethernet frame length
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L720
drivers/ethernet/eth_adin2111.c:720
- }
- else {
+ } else {
|
Run Compliance Tests:
drivers/ethernet/eth_adin2111.c#L737
drivers/ethernet/eth_adin2111.c:737
-
+
/* handle port 2 rx */
if ((status1 & ADIN2111_STATUS1_P2_RX_RDY) && is_adin2111) {
if (ctx->oa) {
ret = eth_adin2111_oa_data_read(dev, 1);
- }
- else {
+ } else {
ret = adin2111_read_fifo(dev, 1U);
}
-
+
|
Loading