driver: regulator: Add support for AXP2101 PMIC #146728
Annotations
16 errors, 11 warnings, and 10 notices
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L78
drivers/regulator/regulator_axp2101.c:78 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L96
drivers/regulator/regulator_axp2101.c:96 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L114
drivers/regulator/regulator_axp2101.c:114 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L132
drivers/regulator/regulator_axp2101.c:132 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L150
drivers/regulator/regulator_axp2101.c:150 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L168
drivers/regulator/regulator_axp2101.c:168 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L186
drivers/regulator/regulator_axp2101.c:186 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L204
drivers/regulator/regulator_axp2101.c:204 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L222
drivers/regulator/regulator_axp2101.c:222 do not use C99 // comments
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L242
drivers/regulator/regulator_axp2101.c:242 do not use C99 // comments
|
|
check-warns:
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
8: UC7 Commit message contains a blocked tag: Change-Id
|
|
check-warns:
Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Missing newline at end of 'drivers/regulator/CMakeLists.txt'. Check your text editor settings.
Missing newline at end of 'drivers/regulator/Kconfig.axp2101'. Check your text editor settings.
Missing newline at end of 'drivers/regulator/regulator_axp2101.c'. Check your text editor settings.
Missing newline at end of 'dts/bindings/regulator/x-powers,axp2101-regulator.yaml'. Check your text editor settings.
|
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:5
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:6
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:7
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:8
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:9
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:14
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:15
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:16
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/Kconfig.axp2101
Line:17
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:78
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:96
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:114
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:132
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:150
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:168
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:186
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:204
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:222
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:242
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:244
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:263
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:264
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:264
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:283
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:284
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:284
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:285
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:285
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:304
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:305
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:305
C99_COMMENTS: do not use C99 // comments
File:drivers/regulator/regulator_axp2101.c
Line:324
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:351
CODE_INDENT: code indent should use tabs where possible
File:drivers/regulator/regulator_axp2101.c
Line:352
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:352
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:372
CODE_INDENT: code indent should use tabs where possible
File:drivers/regulator/regulator_axp2101.c
Line:373
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:373
LEADING_SPACE: please, no spaces at the start of a line
File:drivers/regulator/regulator_axp2101.c
Line:434
LONG_LINE: line length of 101 exceeds 100 columns
File:drivers/regulator/regulat
|
|
check-warns:
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
91cbf52ab8de453949bc49cc132e12c73a235592: author email (dengbaoan <[email protected]>) needs to match one of the signed-off-by entries.
91cbf52ab8de453949bc49cc132e12c73a235592: author email (dengbaoan <[email protected]>) does not follow the syntax: First Last <email>.
|
|
check-warns:
YAMLLint.txt#L1
Check YAML files with YAMLLint.
YAMLLint (new-line-at-end-of-file):no new line character at the end of file
File:dts/bindings/regulator/x-powers,axp2101-regulator.yaml
Line:162
Column:61
|
|
check-warns
Process completed with exit code 1.
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L5
drivers/regulator/Kconfig.axp2101:5 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L6
drivers/regulator/Kconfig.axp2101:6 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L7
drivers/regulator/Kconfig.axp2101:7 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L8
drivers/regulator/Kconfig.axp2101:8 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L9
drivers/regulator/Kconfig.axp2101:9 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L14
drivers/regulator/Kconfig.axp2101:14 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L15
drivers/regulator/Kconfig.axp2101:15 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L16
drivers/regulator/Kconfig.axp2101:16 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/Kconfig.axp2101#L17
drivers/regulator/Kconfig.axp2101:17 please, no spaces at the start of a line
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L264
drivers/regulator/regulator_axp2101.c:264 please, no spaces at the start of a line
|
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-#define XPOWERS_AXP2101_DC_ONOFF_DVM_CTRL (0x80)
-#define XPOWERS_AXP2101_DC_WORKMODE_CTRL (0x81)
-#define XPOWERS_AXP2101_DC_VOL1_CTRL (0x82)
-#define XPOWERS_AXP2101_DC_VOL2_CTRL (0x83)
-#define XPOWERS_AXP2101_DC_VOL3_CTRL (0x84)
-#define XPOWERS_AXP2101_DC_VOL4_CTRL (0x85)
-#define XPOWERS_AXP2101_DC_VOL5_CTRL (0x86)
-#define XPOWERS_AXP2101_DC_OC_CTRL (0x87)
-
-#define XPOWERS_AXP2101_LDO_ONOFF_CTRL0 (0x90)
-#define XPOWERS_AXP2101_LDO_ONOFF_CTRL1 (0x91)
-#define XPOWERS_AXP2101_LDO_VOL_A1_CTRL (0x92)
-#define XPOWERS_AXP2101_LDO_VOL_A2_CTRL (0x93)
-#define XPOWERS_AXP2101_LDO_VOL_A3_CTRL (0x94)
-#define XPOWERS_AXP2101_LDO_VOL_A4_CTRL (0x95)
-#define XPOWERS_AXP2101_LDO_VOL_B1_CTRL (0x96)
-#define XPOWERS_AXP2101_LDO_VOL_B2_CTRL (0x97)
-#define XPOWERS_AXP2101_LDO_VOL_C1_CTRL (0x98)
-#define XPOWERS_AXP2101_LDO_VOL_D1_CTRL (0x99)
-#define XPOWERS_AXP2101_LDO_VOL_D2_CTRL (0x9A)
+#define XPOWERS_AXP2101_DC_ONOFF_DVM_CTRL (0x80)
+#define XPOWERS_AXP2101_DC_WORKMODE_CTRL (0x81)
+#define XPOWERS_AXP2101_DC_VOL1_CTRL (0x82)
+#define XPOWERS_AXP2101_DC_VOL2_CTRL (0x83)
+#define XPOWERS_AXP2101_DC_VOL3_CTRL (0x84)
+#define XPOWERS_AXP2101_DC_VOL4_CTRL (0x85)
+#define XPOWERS_AXP2101_DC_VOL5_CTRL (0x86)
+#define XPOWERS_AXP2101_DC_OC_CTRL (0x87)
+
+#define XPOWERS_AXP2101_LDO_ONOFF_CTRL0 (0x90)
+#define XPOWERS_AXP2101_LDO_ONOFF_CTRL1 (0x91)
+#define XPOWERS_AXP2101_LDO_VOL_A1_CTRL (0x92)
+#define XPOWERS_AXP2101_LDO_VOL_A2_CTRL (0x93)
+#define XPOWERS_AXP2101_LDO_VOL_A3_CTRL (0x94)
+#define XPOWERS_AXP2101_LDO_VOL_A4_CTRL (0x95)
+#define XPOWERS_AXP2101_LDO_VOL_B1_CTRL (0x96)
+#define XPOWERS_AXP2101_LDO_VOL_B2_CTRL (0x97)
+#define XPOWERS_AXP2101_LDO_VOL_C1_CTRL (0x98)
+#define XPOWERS_AXP2101_LDO_VOL_D1_CTRL (0x99)
+#define XPOWERS_AXP2101_LDO_VOL_D2_CTRL (0x9A)
File:drivers/regulator/regulator_axp2101.c
Line:41
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<0,
- .enable_val = 0x01U<<0,
+ .enable_mask = 0x01U << 0,
+ .enable_val = 0x01U << 0,
File:drivers/regulator/regulator_axp2101.c
Line:85
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<1,
- .enable_val = 0x01U<<1,
+ .enable_mask = 0x01U << 1,
+ .enable_val = 0x01U << 1,
File:drivers/regulator/regulator_axp2101.c
Line:103
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<2,
- .enable_val = 0x01U<<2,
+ .enable_mask = 0x01U << 2,
+ .enable_val = 0x01U << 2,
File:drivers/regulator/regulator_axp2101.c
Line:121
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<3,
- .enable_val = 0x01U<<3,
+ .enable_mask = 0x01U << 3,
+ .enable_val = 0x01U << 3,
File:drivers/regulator/regulator_axp2101.c
Line:139
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<4,
- .enable_val = 0x01U<<4,
+ .enable_mask = 0x01U << 4,
+ .enable_val = 0x01U << 4,
File:drivers/regulator/regulator_axp2101.c
Line:157
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<5,
- .enable_val = 0x01U<<5,
+ .enable_mask = 0x01U << 5,
+ .enable_val = 0x01U << 5,
File:drivers/regulator/regulator_axp2101.c
Line:175
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<6,
- .enable_val = 0x01U<<6,
+ .enable_mask = 0x01U << 6,
+ .enable_val = 0x01U << 6,
File:drivers/regulator/regulator_axp2101.c
Line:193
You may want to run clang-format on this change:
- .enable_mask = 0x01U<<7,
- .enable_val = 0x01U<<7,
+ .enable_mask = 0x01U << 7,
+ .enable_val = 0x01U << 7,
File:drivers/regulator/regulator_axp2101.c
L
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L41
drivers/regulator/regulator_axp2101.c:41
-#define XPOWERS_AXP2101_DC_ONOFF_DVM_CTRL (0x80)
-#define XPOWERS_AXP2101_DC_WORKMODE_CTRL (0x81)
-#define XPOWERS_AXP2101_DC_VOL1_CTRL (0x82)
-#define XPOWERS_AXP2101_DC_VOL2_CTRL (0x83)
-#define XPOWERS_AXP2101_DC_VOL3_CTRL (0x84)
-#define XPOWERS_AXP2101_DC_VOL4_CTRL (0x85)
-#define XPOWERS_AXP2101_DC_VOL5_CTRL (0x86)
-#define XPOWERS_AXP2101_DC_OC_CTRL (0x87)
-
-#define XPOWERS_AXP2101_LDO_ONOFF_CTRL0 (0x90)
-#define XPOWERS_AXP2101_LDO_ONOFF_CTRL1 (0x91)
-#define XPOWERS_AXP2101_LDO_VOL_A1_CTRL (0x92)
-#define XPOWERS_AXP2101_LDO_VOL_A2_CTRL (0x93)
-#define XPOWERS_AXP2101_LDO_VOL_A3_CTRL (0x94)
-#define XPOWERS_AXP2101_LDO_VOL_A4_CTRL (0x95)
-#define XPOWERS_AXP2101_LDO_VOL_B1_CTRL (0x96)
-#define XPOWERS_AXP2101_LDO_VOL_B2_CTRL (0x97)
-#define XPOWERS_AXP2101_LDO_VOL_C1_CTRL (0x98)
-#define XPOWERS_AXP2101_LDO_VOL_D1_CTRL (0x99)
-#define XPOWERS_AXP2101_LDO_VOL_D2_CTRL (0x9A)
+#define XPOWERS_AXP2101_DC_ONOFF_DVM_CTRL (0x80)
+#define XPOWERS_AXP2101_DC_WORKMODE_CTRL (0x81)
+#define XPOWERS_AXP2101_DC_VOL1_CTRL (0x82)
+#define XPOWERS_AXP2101_DC_VOL2_CTRL (0x83)
+#define XPOWERS_AXP2101_DC_VOL3_CTRL (0x84)
+#define XPOWERS_AXP2101_DC_VOL4_CTRL (0x85)
+#define XPOWERS_AXP2101_DC_VOL5_CTRL (0x86)
+#define XPOWERS_AXP2101_DC_OC_CTRL (0x87)
+
+#define XPOWERS_AXP2101_LDO_ONOFF_CTRL0 (0x90)
+#define XPOWERS_AXP2101_LDO_ONOFF_CTRL1 (0x91)
+#define XPOWERS_AXP2101_LDO_VOL_A1_CTRL (0x92)
+#define XPOWERS_AXP2101_LDO_VOL_A2_CTRL (0x93)
+#define XPOWERS_AXP2101_LDO_VOL_A3_CTRL (0x94)
+#define XPOWERS_AXP2101_LDO_VOL_A4_CTRL (0x95)
+#define XPOWERS_AXP2101_LDO_VOL_B1_CTRL (0x96)
+#define XPOWERS_AXP2101_LDO_VOL_B2_CTRL (0x97)
+#define XPOWERS_AXP2101_LDO_VOL_C1_CTRL (0x98)
+#define XPOWERS_AXP2101_LDO_VOL_D1_CTRL (0x99)
+#define XPOWERS_AXP2101_LDO_VOL_D2_CTRL (0x9A)
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L85
drivers/regulator/regulator_axp2101.c:85
- .enable_mask = 0x01U<<0,
- .enable_val = 0x01U<<0,
+ .enable_mask = 0x01U << 0,
+ .enable_val = 0x01U << 0,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L103
drivers/regulator/regulator_axp2101.c:103
- .enable_mask = 0x01U<<1,
- .enable_val = 0x01U<<1,
+ .enable_mask = 0x01U << 1,
+ .enable_val = 0x01U << 1,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L121
drivers/regulator/regulator_axp2101.c:121
- .enable_mask = 0x01U<<2,
- .enable_val = 0x01U<<2,
+ .enable_mask = 0x01U << 2,
+ .enable_val = 0x01U << 2,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L139
drivers/regulator/regulator_axp2101.c:139
- .enable_mask = 0x01U<<3,
- .enable_val = 0x01U<<3,
+ .enable_mask = 0x01U << 3,
+ .enable_val = 0x01U << 3,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L157
drivers/regulator/regulator_axp2101.c:157
- .enable_mask = 0x01U<<4,
- .enable_val = 0x01U<<4,
+ .enable_mask = 0x01U << 4,
+ .enable_val = 0x01U << 4,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L175
drivers/regulator/regulator_axp2101.c:175
- .enable_mask = 0x01U<<5,
- .enable_val = 0x01U<<5,
+ .enable_mask = 0x01U << 5,
+ .enable_val = 0x01U << 5,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L193
drivers/regulator/regulator_axp2101.c:193
- .enable_mask = 0x01U<<6,
- .enable_val = 0x01U<<6,
+ .enable_mask = 0x01U << 6,
+ .enable_val = 0x01U << 6,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L211
drivers/regulator/regulator_axp2101.c:211
- .enable_mask = 0x01U<<7,
- .enable_val = 0x01U<<7,
+ .enable_mask = 0x01U << 7,
+ .enable_val = 0x01U << 7,
|
|
Run Compliance Tests:
drivers/regulator/regulator_axp2101.c#L229
drivers/regulator/regulator_axp2101.c:229
- .enable_mask = 0x01U<<0,
- .enable_val = 0x01U<<0,
+ .enable_mask = 0x01U << 0,
+ .enable_val = 0x01U << 0,
|
Loading