Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply security patches for dependencies #4110

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Apply security patches for dependencies #4110

merged 7 commits into from
Jun 3, 2024

Conversation

orien
Copy link
Contributor

@orien orien commented Jun 3, 2024 •
edited
Loading

@orien orien requested a review from grosser as a code owner June 3, 2024 12:05
@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

should just force merge since upgrading actiontext will need a new PR / complete rails upgrade (I can help if you don't have permission)
... maybe we can remove actiontext dependency altogether

@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

actually actiontext can just be removed PR coming ...

@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

... welp no it can't because rails gem depends on it and we can't remove that 😞

@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

so yeah let's merge this and then try a rails upgrade or simply add this vuln to ignores for bundle_audit since we are not using actiontext

@orien
Copy link
Contributor Author

orien commented Jun 3, 2024 •
edited
Loading

Thanks @grosser. I've pushed an ignore for the actiontext CVE.

Please merge at your leisure. I don't have permission.

@orien
Remove unused Rails libraries
04b8d79 
Drops the meta-gem `rails` and the following unused libraries:

- `actionmailbox`
- `actiontext`
- `activestorage`
@orien
Copy link
Contributor Author

orien commented Jun 3, 2024

Change of tack: I've dropped the rails meta-gem and the following unused libraries:

  • actionmailbox
  • actiontext
  • activestorage

@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

oh nice even better :D

@grosser
Copy link
Contributor

grosser commented Jun 3, 2024

was kinda scared that would lead to some rabbithole of other dependencies using rails :D

@grosser grosser merged commit 79fbb3d into zendesk:master Jun 3, 2024
9 checks passed
@orien orien deleted the dependencies branch June 3, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orien @grosser