Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rubocop from 0.93.1 to 1.42.0 #4096

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Bump rubocop from 0.93.1 to 1.42.0 #4096

merged 9 commits into from
Feb 12, 2024

Conversation

orien
Copy link
Contributor

@orien orien commented Feb 12, 2024

No description provided.

grosser
grosser approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly alright,
usually best to bump+disable and then enable+fix in a new PR

@grosser grosser marked this pull request as ready for review February 12, 2024 22:23
@grosser grosser requested a review from a team as a code owner February 12, 2024 22:23
@grosser grosser mentioned this pull request Feb 12, 2024
Merged
@grosser
Copy link
Contributor

grosser commented Feb 12, 2024

is this ready ? ... need it for #4097

@orien
Copy link
Contributor Author

orien commented Feb 12, 2024

:shipit: Thanks @grosser

@grosser grosser merged commit 58f4be0 into zendesk:master Feb 12, 2024
9 checks passed
@orien orien deleted the rubocop branch February 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orien @grosser