Ruby 3 preparation #4092
Merged
Ruby 3 preparation #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
force-pushed
the
ruby-3-preparation
branch
from
d884e69
to
e359899
Compare
orien
force-pushed
the
ruby-3-preparation
branch
from
e359899
to
f961a80
Compare
orien
commented
Feb 11, 2024
Comment on lines
75
to
+81
| VaultClientWrapper.new( | ||
| DEFAULT_CLIENT_OPTIONS.merge( | ||
| address: address, | ||
| ssl_cert_store: cert_store, | ||
| ssl_verify: tls_verify, | ||
| token: token, | ||
| versioned_kv: versioned_kv? | ||
| ) | ||
| **DEFAULT_CLIENT_OPTIONS, | ||
| address: address, | ||
| ssl_cert_store: cert_store, | ||
| ssl_verify: tls_verify, | ||
| token: token, | ||
| versioned_kv: versioned_kv? |
There was a problem hiding this comment.
The VaultClientWrapper class accepts keyword arguments in its initializer. Update this call to match.
orien
commented
Feb 11, 2024
| @@ -24,5 +24,5 @@ class SamsonPlugin < Rails::Engine | |||
|
|
|||
| Samson::Hooks.callback :error do |exception, **options| | |||
| sentry_options = options.slice(:contexts, :extra, :tags, :user, :level, :fingerprint) | |||
| Sentry.capture_exception(exception, sentry_options) | |||
| Sentry.capture_exception(exception, **sentry_options) | |||
There was a problem hiding this comment.
The Sentry.capture_exception method accepts keyword arguments. Update this method call to match.
orien
commented
Feb 11, 2024
| @@ -32,7 +32,7 @@ def new | |||
| case params[:type] | |||
| when "users" | |||
| options = user_filter | |||
| send_data UserCsvPresenter.to_csv(options), type: :csv, filename: "Users_#{options[:datetime]}.csv" | |||
| send_data UserCsvPresenter.to_csv(**options), type: :csv, filename: "Users_#{options[:datetime]}.csv" | |||
There was a problem hiding this comment.
The UserCsvPresenter.to_csv method accepts keyword arguments. Update this method call to match.
samson/app/presenters/user_csv_presenter.rb
Lines 15 to 17 in a370be7
orien
commented
Feb 11, 2024
| ActionCable.server.broadcast channel_name, count: count | ||
| ActionCable.server.broadcast(channel_name, {count: count}) |
There was a problem hiding this comment.
The message sent via the the ActionCable::Server::Broadcasting#broadcast method is a Hash.
Explicitly send a hash in this method call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's a change in Ruby 3.0 that separates positional and keyword arguments.
Change
In preparation for the Ruby 3.0 upgrade, update classes to correctly pass keyword arguments in method calls.