feat(datetime): enhance datetime parsing and validation

src/main/java/com/zendesk/maxwell/bootstrap/SynchronousBootstrapper.java

@@ -14,6 +14,7 @@
 import com.zendesk.maxwell.schema.columndef.ColumnDef;
 import com.zendesk.maxwell.schema.columndef.ColumnDefCastException;
 import com.zendesk.maxwell.schema.columndef.DateColumnDef;
+import com.zendesk.maxwell.schema.columndef.DateTimeColumnDef;
 import com.zendesk.maxwell.schema.columndef.TimeColumnDef;
 import com.zendesk.maxwell.scripting.Scripting;
 import org.slf4j.Logger;
@@ -267,6 +268,8 @@ private void setRowValues(RowMap row, ResultSet resultSet, Table table) throws S
 				columnValue = getTimestamp(resultSet, columnIndex);
 			else if ( columnDefinition instanceof DateColumnDef)
 				columnValue = resultSet.getString(columnIndex);
+			else if ( columnDefinition instanceof DateTimeColumnDef)
+				columnValue = resultSet.getString(columnIndex);
 			else
 				columnValue = resultSet.getObject(columnIndex);
 

src/main/java/com/zendesk/maxwell/schema/columndef/DateColumnDef.java

@@ -1,8 +1,14 @@
 package com.zendesk.maxwell.schema.columndef;
 
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeParseException;
+
 import com.zendesk.maxwell.producer.MaxwellOutputConfig;
 
 public class DateColumnDef extends ColumnDef {
+    private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd");
+
 	private DateColumnDef(String name, String type, short pos) {
 		super(name, type, pos);
 	}
@@ -24,11 +30,18 @@ public String toSQL(Object value) {
 	@Override
 	public Object asJSON(Object value, MaxwellOutputConfig config) throws ColumnDefCastException {
 		if ( value instanceof String ) {
-			// bootstrapper just gives up on bothering with date processing
-			if ( config.zeroDatesAsNull && "0000-00-00".equals((String) value) )
+			String dateString = (String) value;
+
+			if ( config.zeroDatesAsNull && "0000-00-00".equals(dateString) )
 				return null;
-			else
-				return value;
+
+			if ( !DateValidator.isValidDateTime(dateString) )
+				return null;
+
+			value = parseDate(dateString);
+			if (value == null) {
+				return null;
+			}
 		} else if ( value instanceof Long && (Long) value == Long.MIN_VALUE ) {
 			if ( config.zeroDatesAsNull )
 				return null;
@@ -42,4 +55,12 @@ public Object asJSON(Object value, MaxwellOutputConfig config) throws ColumnDefC
 			throw new ColumnDefCastException(this, value);
 		}
 	}
+
+	private Object parseDate(String dateString) {
+		try {
+			return LocalDate.parse(dateString, DATE_FORMATTER);
+		} catch (DateTimeParseException e) {
+			return null;
+		}
+	}
 }

src/main/java/com/zendesk/maxwell/schema/columndef/DateFormatter.java

@@ -1,6 +1,7 @@
 package com.zendesk.maxwell.schema.columndef;
 
 import java.sql.Timestamp;
+import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.*;
 
@@ -23,6 +24,9 @@ public static Timestamp extractTimestamp(Object value) throws IllegalArgumentExc
 		} else if ( value instanceof Date ) {
 			Long time = ((Date) value).getTime();
 			return new Timestamp(time);
+		} else if ( value instanceof LocalDate ) {
+			LocalDateTime startOfDay = ((LocalDate) value).atStartOfDay();
+			return Timestamp.valueOf(startOfDay);
 		}  else if ( value instanceof LocalDateTime) {
 			return Timestamp.valueOf((LocalDateTime) value);
 		} else

src/main/java/com/zendesk/maxwell/schema/columndef/DateTimeColumnDef.java

@@ -3,8 +3,12 @@
 import com.zendesk.maxwell.producer.MaxwellOutputConfig;
 
 import java.sql.Timestamp;
+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeParseException;
 
 public class DateTimeColumnDef extends ColumnDefWithLength {
+    private static final DateTimeFormatter DATE_TIME_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
 
 	private final boolean isTimestamp = getType().equals("timestamp");
 
@@ -19,7 +23,20 @@ public static DateTimeColumnDef create(String name, String type, short pos, Long
 
 	protected String formatValue(Object value, MaxwellOutputConfig config) throws ColumnDefCastException {
 		// special case for those broken mysql dates.
-		if ( value instanceof Long ) {
+		if ( value instanceof String) {
+			String dateString = (String) value;
+
+			if ( config.zeroDatesAsNull && "0000-00-00 00:00:00".equals(dateString) )
+				return null;
+
+			if ( !DateValidator.isValidDateTime(dateString) )
+				return null;
+
+			value = parseDateTime(dateString);
+			if (value == null) {
+				return null;
+			}
+		} else if ( value instanceof Long ) {
 			Long v = (Long) value;
 			if ( v == Long.MIN_VALUE || (v == 0L && isTimestamp) ) {
 				if ( config.zeroDatesAsNull )
@@ -37,4 +54,12 @@ protected String formatValue(Object value, MaxwellOutputConfig config) throws Co
 			throw new ColumnDefCastException(this, value);
 		}
 	}
+
+	private Object parseDateTime(String dateString) {
+		try {
+			return LocalDateTime.parse(dateString, DATE_TIME_FORMATTER);
+		} catch (DateTimeParseException e) {
+			return null;
+		}
+	}
 }

src/main/java/com/zendesk/maxwell/schema/columndef/DateValidator.java

@@ -0,0 +1,11 @@
+package com.zendesk.maxwell.schema.columndef;
+
+public class DateValidator {
+    private static final String DATE_TIME_REGEX = 
+    "^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])" +
+    "( (0[0-9]|1[0-9]|2[0-3]):([0-5][0-9]):([0-5][0-9]))?$";
+
+    public static boolean isValidDateTime(String dateString) {
+        return dateString.matches(DATE_TIME_REGEX);
+    }
+}

src/test/java/com/zendesk/maxwell/schema/columndef/ColumnDefTest.java

@@ -290,6 +290,46 @@ public void TestDateTimeZeroDates() throws ColumnDefCastException {
 		assertEquals(null, d.asJSON(Long.MIN_VALUE, config));
 	}
 
+	@Test
+	public void TestDateBadMonth() throws ColumnDefCastException {
+		ColumnDef d = build("date", true);
+
+		MaxwellOutputConfig config = new MaxwellOutputConfig();
+		config.zeroDatesAsNull = true;
+
+		assertEquals(null, d.asJSON("2020-00-01", config));
+	}
+
+	@Test
+	public void TestDateBadDay() throws ColumnDefCastException {
+		ColumnDef d = build("date", true);
+
+		MaxwellOutputConfig config = new MaxwellOutputConfig();
+		config.zeroDatesAsNull = true;
+
+		assertEquals(null, d.asJSON("2020-01-00", config));
+	}
+
+	@Test
+	public void TestDatetimeBadDay() throws ColumnDefCastException {
+		ColumnDef d = build("datetime", true);
+
+		MaxwellOutputConfig config = new MaxwellOutputConfig();
+		config.zeroDatesAsNull = true;
+
+		assertEquals(null, d.asJSON("2020-01-00 00:00:00", config));
+	}
+
+	@Test
+	public void TestDatetimeBadMonth() throws ColumnDefCastException {
+		ColumnDef d = build("datetime", true);
+
+		MaxwellOutputConfig config = new MaxwellOutputConfig();
+		config.zeroDatesAsNull = true;
+
+		assertEquals(null, d.asJSON("2020-00-01 00:00:00", config));
+	}
+
 	@Test
 	public void TestDateTimeWithTimestamp() throws ParseException, ColumnDefCastException {
 		ColumnDef d = build("datetime", true);