-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all fractional places #1049
Merged
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7139001
Create AlignedFractionalTransactAsset struct
sea212 aa56d29
Implement adjusted deposit_asset
sea212 1b3d944
Make compileable
sea212 e8afa4c
Allign fractional decimal places on Battery Station
sea212 f299eb7
Partially implement tests on Battery Station
sea212 d24e39a
User proper adjusted transfer values in tests
sea212 fae3d54
Finalize tests on Battery Station
sea212 9eae276
Align fractional decimal places on Zeitgeist
sea212 b79847f
Add btc test to Zeitgeist
sea212 a0f9f0f
Extended Zeitgeist XCM test with ETH (18 decimals)
sea212 9852c83
Cargo fmt
sea212 ddc11bf
Use BASE representation in token metadata
sea212 31ce472
Align decimal places for transfers
sea212 354f7c4
Merge branch 'main' into sea212-support-all-fractional-places
sea212 0858154
Update changelog + format
sea212 6326d6f
Satisfy Clippy
sea212 7fca3c1
Update runtime/zeitgeist/src/xcm_config/fees.rs
sea212 218bd90
Update runtime/zeitgeist/src/xcm_config/fees.rs
sea212 c29b49c
Apply suggestions from code review
sea212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reformatted using prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of line 22 is intentional, it is a sub point of the one in line 21.