-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions #1047
Update versions #1047
Conversation
Also removes unused code and modifies changelog layout for v0.3.10
@@ -12,10 +12,12 @@ https://keepachangelog.com/en/1.0.0/ and ⚠️ marks changes that might break | |||
components which query the chain's storage, the extrinsics or the runtime | |||
APIs/RPC interface. | |||
|
|||
## v0.4.0 | |||
## v0.3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the threshold to exceed to come to 0.4.0
? Major changes that are defined how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We take https://semver.org/ as a guideline.
Given a version number MAJOR.MINOR.PATCH, increment the:
[...]
MINOR version when you add functionality in a backward compatible manner
Obviously we added some new functionality here, this happens every release. The functionality that we added usually assists in using the protocol or changes existing core functionality. I consider new functionality as additions to the core protocol. For example, Court, AMM 2.0, Liquidity Mining, etc. would lead to a bump in the MINOR version from my perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe AMM 2.0 turns out to be backwards incompatible, in that case a MAJOR version bump would be necessary. However, Malte informed me that before 1.0.0
, a MINOR bump can be done instead as defined in semver.
What does it do?
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References