Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions #1047

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Update versions #1047

merged 1 commit into from
Jul 21, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Jul 20, 2023

What does it do?

  • Update crate and runtime version
  • Also removes unused code and modifies changelog layout for v0.3.10

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

Also removes unused code and modifies changelog layout for v0.3.10
@sea212 sea212 added the s:review-needed The pull request requires reviews label Jul 20, 2023
@sea212 sea212 added this to the v0.3.10 milestone Jul 20, 2023
@sea212 sea212 self-assigned this Jul 20, 2023
@@ -12,10 +12,12 @@ https://keepachangelog.com/en/1.0.0/ and ⚠️ marks changes that might break
components which query the chain's storage, the extrinsics or the runtime
APIs/RPC interface.

## v0.4.0
## v0.3.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the threshold to exceed to come to 0.4.0? Major changes that are defined how?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We take https://semver.org/ as a guideline.

Given a version number MAJOR.MINOR.PATCH, increment the:
[...]
MINOR version when you add functionality in a backward compatible manner

Obviously we added some new functionality here, this happens every release. The functionality that we added usually assists in using the protocol or changes existing core functionality. I consider new functionality as additions to the core protocol. For example, Court, AMM 2.0, Liquidity Mining, etc. would lead to a bump in the MINOR version from my perspective.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe AMM 2.0 turns out to be backwards incompatible, in that case a MAJOR version bump would be necessary. However, Malte informed me that before 1.0.0, a MINOR bump can be done instead as defined in semver.

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jul 21, 2023
@sea212 sea212 merged commit 27da42c into release-v0.3.10 Jul 21, 2023
21 checks passed
@sea212 sea212 deleted the sea212-update-versions branch July 21, 2023 10:16
sea212 added a commit that referenced this pull request Jul 24, 2023
* Update versions (#1047)

Update version

Also removes unused code and modifies changelog layout for v0.3.10

* Update weights (#1048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants