Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup a few different things #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

cleanup a few different things #1

wants to merge 6 commits into from

Conversation

davisshaver
Copy link

@davisshaver davisshaver commented May 21, 2018

  • Adds composer.json
  • Checks for featured image ID before using
  • Improves type checking to prevent PHP error

@davisshaver
Copy link
Author

Could I get a review/merge on this? 😄

@lewayotte
Copy link
Contributor

Sorry for the delay, just got back from a work trip in San Antonio. Just curious, any particular reason why you're including the composer file? We generally don't use composer for our dev.

@davisshaver
Copy link
Author

@lewayotte I gotcha.. My thought is that even though we aren't using Composer for dependency management, adding the composer.json will make the plugin easier to use in a WP stack managed by composer. We just need to declare the name and type in a composer.json and then the plugin can be managed as a dependency in composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants