Add initial FreeBSD support #20480
Merged
Add initial FreeBSD support #20480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @CalebHeydon on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
SomeoneToIgnore
approved these changes
Nov 11, 2024
| @@ -33,11 +33,16 @@ impl KeyContext { | |||
| let mut context = Self::default(); | |||
| #[cfg(target_os = "macos")] | |||
| context.set("os", "macos"); | |||
| #[cfg(target_os = "linux")] | |||
| #[cfg(any(target_os = "linux", target_os = "freebsd"))] | |||
| context.set("os", "linux"); | |||
There was a problem hiding this comment.
This and another place below with Self::Linux looks quite odd, so welcome to fix in in the future PRs.
There was a problem hiding this comment.
Thanks for pointing that out. It probably is correct to set the context to linux, but I'll need to prevent it from setting it to unknown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for FreeBSD (#15309). While there is still work left to be done, it seems to be usable. As discussed by @syobocat (#10247), the changes were just adding
target_os = "freebsd"to wherever it checks if the OS is Linux.Needs to be build with
RUSTFLAGS="-C link-dead-code"Known Issues:
crates/project/src/environment.rswhere a command fails because/bin/shon FreeBSD doesn't support the-loption.ashpdcrate don't work on FreeBSD (at least with KDE). This isn't that bad since a fallback dialog is used.Release Notes: