Fix proxy settings retrieval on startup

[ClanEver]

Closes #18155

Release Notes:

• N/A

[zed-industries-bot]

	Messages
📖	This PR includes links to the following GitHub Issues: #18155 If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 8e8396c

[SomeoneToIgnore]

@JunkuiZhang , would you want to have a peek at this?

[JunkuiZhang]

@SomeoneToIgnore I’ve been extremely busy lately. I’m currently participating in a competition with tight deadlines and heavy workloads, leaving me with almost no rest. If it’s okay, the competition will be over in about two days, and I’ll have much more time to focus on this.

From my perspective, this PR needs more detailed description. At the very least, it should explain the root cause of the original issue and why this PR resolves it. This would make the review process smoother and quicker, and also increase the chances of your PR being merged.

From a quick look, it seems like handle_settings_file_changes just displays a notification window when the settings file encounters an error. I’m not sure why moving the call to this function before client::init_settings(cx); would fix the issue.

Additionally, I’m curious about how this change might affect #15446.

[SomeoneToIgnore]

Sorry, I was unaware of this, it's totally ok to ignore my message entirely if needed.
Thank you for a quick review.

[ClanEver]

I apologize for not explaining this PR, which wasted some of your time.

I've reviewed #15446.

It appears that all HTTP requests use the HTTP client created here: let http = IsahcHttpClient::new(proxy_url, Some(user_agent));.

Before:

1. let proxy_str = ProxySettings::get_global(cx).proxy.to_owned(); reads the proxy settings from the global SettingsStore.
2. handle_settings_file_changes(user_settings_file_rx, cx, handle_settings_changed); reads settings from the file into the global SettingsStore, including the proxy.

So before the modification, the proxy settings from the settings file were ignored, causing proxy_str to always be None.

After:
By reading the settings from the file first, then let proxy_str = ProxySettings::get_global(cx).proxy.to_owned(); becomes correct.

I just tested that simply placing handle_settings_file_changes(user_settings_file_rx, cx, handle_settings_changed); before let proxy_str = ProxySettings::get_global(cx).proxy.to_owned(); works. When submitting the PR, I referred to the order before the changes in #15446, thinking it needed to be placed before client::init_settings(cx); to work.

[JunkuiZhang]

Sorry, I was unaware of this, it's totally ok to ignore my message entirely if needed. Thank you for a quick review.

@SomeoneToIgnore There's no need to be sorry, my friend. I can still read and reply emails and github notifications everyday.

[ConradIrwin]

Thanks for this!