Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Fix with Assistant" code action on lines with diagnostics #18163

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Add "Fix with Assistant" code action on lines with diagnostics #18163

merged 14 commits into from
Sep 23, 2024

Commits on Sep 20, 2024

  1. Introduce a new CodeActionProvider trait in editor 

    This paves the way for AI-assisted refactorings.

Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    82a8e53 View commit details
    Browse the repository at this point in the history

  2. WIP

    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6c5b67b View commit details
    Browse the repository at this point in the history

  3. Start inline assistant when accepting code action

    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aeca84c View commit details
    Browse the repository at this point in the history

  4. Expand excerpt if needed when applying "Fix with AI" code action

    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    83fcd46 View commit details
    Browse the repository at this point in the history

  5. Suggest "Fix with AI" when diagnostic is elsewhere on a line

    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ed971a4 View commit details
    Browse the repository at this point in the history

  6. Change title to Fix with Assistant 

    Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7c29812 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into ai-code-actions 

    # Conflicts:
#	crates/assistant/src/inline_assistant.rs
    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c33243e View commit details
    Browse the repository at this point in the history

  8. Fix clippy 

    Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2c07815 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into ai-code-actions

    @as-cii
    as-cii committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    14f38f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Merge remote-tracking branch 'origin/main' into ai-code-actions

    @as-cii
    as-cii committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    15c561b View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Hardcode num_cpus to 4 in tests 

    This would cause non-determinism because we can't know how many CPUs
we'll have on the machine that runs the test.

Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    35599c8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into ai-code-actions 

    # Conflicts:
#	crates/project/src/lsp_store.rs
    @as-cii
    as-cii committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f3458f4 View commit details
    Browse the repository at this point in the history

  3. Wait until SSH project has fully been scanned before sharing it 

    This fixes a test that was failing after we fixed some non-determinism
caused by `num_cpus` (see 35599c8), but it really is just a bandaid that's
hiding an actual problem we have in production.

We think there's some race condition that can happen when a host shares via SSH
before the worktree has fully been scanned, and at the same time a guest joins.

/cc: @ConradIrwin

Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ff3d338 View commit details
    Browse the repository at this point in the history

  4. Fix test 

    The order changed after 35599c8.

Co-Authored-By: Nathan <[email protected]>
    @as-cii @nathansobo
    as-cii and nathansobo committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3d1627d View commit details
    Browse the repository at this point in the history