Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpui: Fix show: false support on Windows to create an invisible window #18161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Sep 20, 2024

Release Notes:

  • N/A

The show of WindowOptions is valid on macOS but not on Windows, this changes to fix it to support create an invisible window.

cargo run -p gpui --example window

Before

before.2024-09-21.031338.mp4

After

after.2024-09-21.031151.mp4

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 20, 2024
@huacnlee huacnlee changed the title windows: Fix show: false support on Windows to create a invisable w… windows: Fix show: false support on Windows to create an invisible window Sep 20, 2024
@huacnlee huacnlee changed the title windows: Fix show: false support on Windows to create an invisible window gpui: Fix show: false support on Windows to create an invisible window Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant