Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Switch Protobuf checks to non-deprecated bufbuild/buf-action #18037

Closed
wants to merge 11 commits into from
Closed

ci: Switch Protobuf checks to non-deprecated bufbuild/buf-action #18037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3bedf2b
ci: Switch Proto-buf checks to non-deprecated bufbuild/buf-action.
notpeter Sep 18, 2024
39c92bc
Update .github/workflows/ci.yml
notpeter Sep 18, 2024
4783fe1
Bump buf-action to newest (v1.41.0) as buf-action requires buf >= v1.…
notpeter Sep 18, 2024
c772f87
No v maybe?
notpeter Sep 18, 2024
2d62e50
Apply buf format
notpeter Sep 18, 2024
4aad214
Rewind a bit on the buf version.
notpeter Sep 18, 2024
fd47471
Reformat proto.
notpeter Oct 1, 2024
375537b
Merge branch 'main' into buf_action
notpeter Oct 1, 2024
7b0a239
Disable linting.
notpeter Oct 1, 2024
2e36aaf
Renamed config option.
notpeter Oct 1, 2024
3efbd3a
Maybe GITHUB_BASE_REF?
notpeter Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ jobs:
echo "BUF_BASE_BRANCH=$GITHUB_BASE_REF" >> $GITHUB_ENV
fi

- uses: bufbuild/buf-setup-action@v1
with:
version: v1.29.0
- uses: bufbuild/buf-breaking-action@v1
- name: Protobuf checks
uses: bufbuild/buf-action@v1
with:
version: 1.35.0
input: "crates/proto/proto/"
against: "https://github.com/${GITHUB_REPOSITORY}.git#branch=${BUF_BASE_BRANCH},subdir=crates/proto/proto/"
breaking_against: "https://github.com/${GITHUB_REPOSITORY}.git#branch=${GITHUB_BASE_REF},subdir=crates/proto/proto/"
lint: false

macos_tests:
timeout-minutes: 60
Expand Down
3 changes: 3 additions & 0 deletions .zed/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
"RUST_DEFAULT_PACKAGE_RUN": "zed"
}
}
},
"proto": {
"tab_size": 2
}
},
"file_types": {
Expand Down
Loading
Loading