Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypher language extension #1658

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add Cypher language extension #1658

merged 2 commits into from
Nov 12, 2024

Conversation

pupli
Copy link
Contributor

@pupli pupli commented Nov 11, 2024

Adding the Cypher extension

Syntax highlighting for cypher query language
Grammar are based on OpenCypherLink
To test the highlights use refer the examples in Test Cypher Queries

Copy link

cla-bot bot commented Nov 11, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @paihari on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@pupli
Copy link
Contributor Author

pupli commented Nov 11, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 11, 2024
Copy link

cla-bot bot commented Nov 11, 2024

The cla-bot has been summoned, and re-checked this pull request!

@notpeter
Copy link
Member

Can you merge main into your branch and re push.

In the future if you commit your changes to a branch other than to main on your fork and check the "Allow Maintainers to Make Changes" we can do this for you.

Copy link

cla-bot bot commented Nov 12, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @pupli on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot cla-bot bot removed the cla-signed label Nov 12, 2024
@pupli
Copy link
Contributor Author

pupli commented Nov 12, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 12, 2024
Copy link

cla-bot bot commented Nov 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

@pupli
Copy link
Contributor Author

pupli commented Nov 12, 2024

@notpeter Hope this is what was needed.
Though i remember checking Allow Maintainers to Make Changes as true.

@pupli
Copy link
Contributor Author

pupli commented Nov 12, 2024

Snip20241112_3

@notpeter notpeter changed the title Add Cypher extension Add Cypher language extension Nov 12, 2024
@notpeter notpeter merged commit e1d7cc7 into zed-industries:main Nov 12, 2024
3 checks passed
@notpeter
Copy link
Member

Thanks! You got it. Congrats on your first extension!

@pupli
Copy link
Contributor Author

pupli commented Nov 12, 2024

Thank you, it gives a sense of satisfaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants