-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BlockCache trait for FsBlockDb #1535
Open
Oscar-Pepper
wants to merge
9
commits into
zcash:main
Choose a base branch
from
Oscar-Pepper:impl_block_cache_for_fsblockdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement BlockCache trait for FsBlockDb #1535
Oscar-Pepper
wants to merge
9
commits into
zcash:main
from
Oscar-Pepper:impl_block_cache_for_fsblockdb
Commits on Oct 28, 2024
-
zcash_client_backend: Switch from
async-trait
to RPIT forBlockCache
The `BlockCache::truncate` default method is removed because the `trait-variant` crate does not yet support default methods.
Configuration menu - View commit details
-
Copy full SHA for 6f9390b - Browse repository at this point
Copy the full SHA 6f9390bView commit details
Commits on Oct 29, 2024
-
zcash_client_backend: Generalise
BlockSource::with_blocks
errorInstead of requiring `zcash_client_backend::data_api::chain::Error`, it now works with any error type that `BlockSource::Error` can be converted into. We require an explicit conversion function instead of using `From` because in the specific case of `data_api::chain::Error` it would result in conflicting `From` impls.
Configuration menu - View commit details
-
Copy full SHA for 36144f9 - Browse repository at this point
Copy the full SHA 36144f9View commit details -
implement Sync for FsBlockDb and BlockDb so they can implement BlockC…
…ache trait Co-authored-by: Jack Grigg <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95649dc - Browse repository at this point
Copy the full SHA 95649dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3bf952 - Browse repository at this point
Copy the full SHA d3bf952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cf2d9 - Browse repository at this point
Copy the full SHA 69cf2d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b7714 - Browse repository at this point
Copy the full SHA 22b7714View commit details -
Configuration menu - View commit details
-
Copy full SHA for 163dbc7 - Browse repository at this point
Copy the full SHA 163dbc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d1c710 - Browse repository at this point
Copy the full SHA 3d1c710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 020438c - Browse repository at this point
Copy the full SHA 020438cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.