Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_primitives: Refactor Transaction to permit omitting protocol-specific bundles #1388

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

zcash_primitives: Extract bundle-specific parts of tx serialization

822cd36
Select commit
Loading
Failed to load commit list.
Open

zcash_primitives: Refactor Transaction to permit omitting protocol-specific bundles #1388

zcash_primitives: Extract bundle-specific parts of tx serialization
822cd36
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 8, 2024 in 0s

75.88% of diff hit (target 61.62%)

View this Pull Request on Codecov

75.88% of diff hit (target 61.62%)

Annotations

Check warning on line 212 in devtools/src/bin/inspect/transaction.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

devtools/src/bin/inspect/transaction.rs#L212

Added line #L212 was not covered by tests

Check warning on line 80 in zcash_primitives/src/transaction/components.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components.rs#L80

Added line #L80 was not covered by tests

Check warning on line 82 in zcash_primitives/src/transaction/components.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components.rs#L82

Added line #L82 was not covered by tests

Check warning on line 95 in zcash_primitives/src/transaction/components.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components.rs#L94-L95

Added lines #L94 - L95 were not covered by tests

Check warning on line 56 in zcash_primitives/src/transaction/components/sprout.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/sprout.rs#L56

Added line #L56 was not covered by tests

Check warning on line 235 in zcash_primitives/src/transaction/components/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/transparent.rs#L235

Added line #L235 was not covered by tests

Check warning on line 239 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L234-L239

Added lines #L234 - L239 were not covered by tests

Check warning on line 244 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L241-L244

Added lines #L241 - L244 were not covered by tests

Check warning on line 248 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L248

Added line #L248 was not covered by tests

Check warning on line 260 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L257-L260

Added lines #L257 - L260 were not covered by tests

Check warning on line 263 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L262-L263

Added lines #L262 - L263 were not covered by tests

Check warning on line 267 in zcash_primitives/src/transaction/components/tze.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/components/tze.rs#L267

Added line #L267 was not covered by tests

Check warning on line 378 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L369-L378

Added lines #L369 - L378 were not covered by tests

Check warning on line 381 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L380-L381

Added lines #L380 - L381 were not covered by tests

Check warning on line 485 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L485

Added line #L485 was not covered by tests

Check warning on line 541 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L541

Added line #L541 was not covered by tests

Check warning on line 566 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L566

Added line #L566 was not covered by tests

Check warning on line 576 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L576

Added line #L576 was not covered by tests

Check warning on line 661 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L661

Added line #L661 was not covered by tests

Check warning on line 742 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L742

Added line #L742 was not covered by tests

Check warning on line 778 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L778

Added line #L778 was not covered by tests

Check warning on line 862 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L862

Added line #L862 was not covered by tests

Check warning on line 871 in zcash_primitives/src/transaction/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/mod.rs#L870-L871

Added lines #L870 - L871 were not covered by tests

Check warning on line 95 in zcash_primitives/src/transaction/sighash_v4.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/sighash_v4.rs#L94-L95

Added lines #L94 - L95 were not covered by tests

Check warning on line 100 in zcash_primitives/src/transaction/sighash_v4.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_primitives/src/transaction/sighash_v4.rs#L99-L100

Added lines #L99 - L100 were not covered by tests