Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: add indoor=* tiles #480

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Map: add indoor=* tiles #480

wants to merge 4 commits into from

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Aug 21, 2024

DEMO: https://osmapp-git-indoor-osm-app-team.vercel.app/

Proof of concept for Indoor tiles 🎉 - aka #225

Thanks contrapunctus for heads up about indoorequal service. And @francois2metz for creating it ofc! 😃👍

More links:

TODO

  • attribution
  • indoor disappears when switching layers
  • make indoor default (how?) 🤔
  • tilting: When I tried to tilt the map (via 2 finger swipe), I managed to break the indoor rendering. Rooms and corridors were no longer rendered, even though the Indoor layer was active. Once I turned the layer off and on again, the rooms and corridors were displayed once more, and tilting the map now tilted the indoor data too - pretty cool! I can reproduce this consistently in Fennec F-Droid 129.0.2 (Android) and Firefox 131 (desktop). I've attached the console output from the latter.
  • the Louvre https://osmapp-git-indoor-osm-app-team.vercel.app/#18.45/48.8610/2.3389 Here, OsmAPP's level selector doesn't do too well on phones - it goes off-screen at the bottom. Could users scroll the level selector up and down? IndoorEqual does this on desktop, but on phones the pull-down motion conflicts with the pull-to-refresh gesture.
  • maybe: consider if we can stack the floor to their relative height! Speaking of tilting - currently, all indoor data is currently shown as if it was on the ground floor of the building. Would it be very difficult to show the data higher/lower, based on the value of level=* + the building height? (Building heights are not commonly tagged in OSM, so renderers usually assume a height of 3 meters per building level.)

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 4, 2024 10:51am

@zbycz zbycz changed the title Map: add indoor= tiles Map: add indoor=* tiles Aug 21, 2024
@zbycz zbycz marked this pull request as draft August 21, 2024 14:17
@francois2metz
Copy link

Hi,
Great integration!
I would recommend to switch to the package maplibre-gl-indoorequal, I forgot to update some documentation.

Not sure what are you plan, but you may want to hide the heatmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants