Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchBox: Redesign #430

Merged
merged 3 commits into from
Oct 4, 2024
Merged

SearchBox: Redesign #430

merged 3 commits into from
Oct 4, 2024

Conversation

jvaclavik
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 4, 2024 9:52am

@zbycz zbycz mentioned this pull request Sep 28, 2024
Open
@jvaclavik
Copy link
Collaborator Author

@Dlurak feel free to take this PR if you want

@Dlurak Dlurak marked this pull request as ready for review October 4, 2024 08:45
@Dlurak
Copy link
Collaborator

Dlurak commented Oct 4, 2024

I think that was the only thing missing, merging master into this branch, right?

@zbycz
Copy link
Owner

zbycz commented Oct 4, 2024 •
edited
Loading

Yes, there were only some conflicts I believe.

I quickly checked this, and there is some issue with z-index condition, when Directions are displayed - see below. After/if you fix it, please feel free to merge it :)

image

@Dlurak Dlurak enabled auto-merge (squash) October 4, 2024 09:51
@Dlurak Dlurak merged commit 2c6ea76 into master Oct 4, 2024
2 checks passed
@Dlurak Dlurak deleted the redesign-search-box branch October 4, 2024 09:52
@Dlurak
Copy link
Collaborator

Dlurak commented Oct 6, 2024 •
edited
Loading

This broke scrolling on desktop. You can't scroll to the complete bottom
Here it needs to be 100%-searchbox height instead of 100%

@zbycz
Copy link
Owner

zbycz commented Oct 7, 2024

This broke scrolling on desktop. You can't scroll to the complete bottom Here it needs to be 100%-searchbox height instead of 100%

Thanks for noticing it and for the fix in #634 👍

@zbycz zbycz mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvaclavik @Dlurak @zbycz