Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing object selection bug in field_planner, updating geodata_picker and delete-dialogs #109

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

LukasBaecker
Copy link
Contributor

@LukasBaecker LukasBaecker commented Jul 5, 2024

  • Following the latest big refactoring a small bug appeared with the selection of objects. When adding points to an object, the point was added to all objects.

  • Dialogs when hitting a delete button should be added so that fields or objects get deleted by accident.

  • The geodata-picker needs to be tested and fixed.

  • fixing object selection issue

  • adding delete-dialogs

  • fixing geodata-picker

added:

  • test functionality and fix bugs in field planner

@LukasBaecker LukasBaecker changed the title fixing object selection bug in field_planner, and updating geodata_picker fixing object selection bug in field_planner, updating geodata_picker Jul 5, 2024
@LukasBaecker LukasBaecker changed the title fixing object selection bug in field_planner, updating geodata_picker fixing object selection bug in field_planner, updating geodata_picker and delete-dialogs Jul 5, 2024
@LukasBaecker
Copy link
Contributor Author

There are multiple more bugs that have crept into the field planner lately. I am testing the whole functionality again and try to fix all of them.

@rodja rodja added this to the 0.3.0 milestone Aug 18, 2024
@rodja rodja added the bug Something isn't working label Aug 18, 2024
@@ -160,9 +157,9 @@ def active_field(self, field_id: str | None) -> None:
self._active_field = field_id
self.update_layers()

# FIXME diese funktion muss wieder gerade gebogen werden und außerdem muss der button wieder in das Menü eingefügt werden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to english in the whole code. Including all comments!

@LukasBaecker LukasBaecker marked this pull request as ready for review August 29, 2024 13:26
@angelom93 angelom93 merged commit 90a64a0 into main Aug 30, 2024
1 check passed
@angelom93 angelom93 deleted the field_planner-bug-fixing branch August 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants