Updating recency_end_date reference #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recency_end_date variable is referencing the user passed variable value and not the class attribute that is transformed using the strptime() function: self.data = convert_transaction_to_user(self.data, recency_end_date=recency_end_date) The variable should be prefixed with the self. keyword: self.data = convert_transaction_to_user(self.data, recency_end_date=self.recency_end_date) This is causing an issue when the recency_end_date value is passed to the convert_transaction_to_user() function, specifically on this line of code: df_recency = df.groupby([id_col])[date_col].max().apply(lambda date: (end_date - date).days).astype(float) TypeError: unsupported operand type(s) for -: 'str' and 'Timestamp'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recency_end_date variable is referencing the user passed variable value and not the class attribute that is transformed using the strptime() function:
self.data = convert_transaction_to_user(self.data, recency_end_date=recency_end_date)
The variable should be prefixed with the self. keyword:
self.data = convert_transaction_to_user(self.data, recency_end_date=self.recency_end_date)
This is causing an issue when the recency_end_date value is passed to the convert_transaction_to_user() function, specifically on this line of code:
df_recency = df.groupby([id_col])[date_col].max().apply(lambda date: (end_date - date).days).astype(float)
TypeError: unsupported operand type(s) for -: 'str' and 'Timestamp'