ascanrulesBeta & pscanrules: CSRF rules ignore GET unless Low threshold #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
force-pushed
the
csrf-get
branch
2 times, most recently
from
bc19141
to
ba475bd
Compare
|
No longer conflicting |
ricekot
reviewed
Sep 13, 2024
...ain/javahelp/org/zaproxy/zap/extension/ascanrulesBeta/resources/help/contents/ascanbeta.html
Outdated
Show resolved
Hide resolved
...c/main/javahelp/org/zaproxy/zap/extension/pscanrules/resources/help/contents/pscanrules.html
Outdated
Show resolved
Hide resolved
...esBeta/src/test/java/org/zaproxy/zap/extension/ascanrulesBeta/CsrfTokenScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
csrf-get
branch
from
ba475bd
to
d9c72ac
Compare
|
Review addressed. |
ricekot
reviewed
Sep 16, 2024
.../src/test/java/org/zaproxy/zap/extension/pscanrules/CsrfCountermeasuresScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
csrf-get
branch
from
d9c72ac
to
45bd705
Compare
|
Fixed |
ricekot
approved these changes
Sep 17, 2024
kingthorin
force-pushed
the
csrf-get
branch
from
45bd705
to
7a4fb2c
Compare
|
Deconflicted |
kingthorin
force-pushed
the
csrf-get
branch
from
7a4fb2c
to
c749c13
Compare
ricekot
approved these changes
Sep 19, 2024
thc202
reviewed
Sep 19, 2024
...ain/javahelp/org/zaproxy/zap/extension/ascanrulesBeta/resources/help/contents/ascanbeta.html
Outdated
Show resolved
Hide resolved
...c/main/javahelp/org/zaproxy/zap/extension/pscanrules/resources/help/contents/pscanrules.html
Outdated
Show resolved
Hide resolved
- CHANGELOGs > Added change note. - Scan Rules > Added condition to bail of now Low threshold and GET request. - Unit Tests > Updated to assert the new behavior and leverage parameterized tests. - Help files > Updated to note the new condition. Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
csrf-get
branch
from
c749c13
to
2fe8165
Compare
|
Got all those, thanks for the review. |
thc202
approved these changes
Sep 19, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
Fixes zaproxy/zaproxy#7741
Checklist
./gradlew spotlessApplyfor code formatting