Skip to content

Commit

Permalink
Int: Fix docker-building CI workflows (#405)
Browse files Browse the repository at this point in the history
# The problem
Docker images were not building due to wrong paths in CICD workflows

# This PR's solution
Fix paths and examples

# Checklist

_Check that this PR satisfies the following items:_

- [x] Tests have been added for new features/changed behavior (if no new
features have been added, check the box).
- [x] The [changelog file](CHANGELOG.md) has been updated with a
user-readable description of the changes (if the change isn't visible to
the user in any way, check the box).
- [x] The PR's title is prefixed with
`<feat/fix/chore/imp[rovement]/int[ernal]/docs>[!]:`
- [x] The PR is linked to a JIRA ticket (if there's no suitable ticket,
check the box).
  • Loading branch information
SebastianMorawiec authored May 13, 2024
1 parent b84b74e commit 2e059f4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/publish-cuda-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ on:
description: |
Orquestra SDK requirement to build the image with.
Example of using a published version of the SDK:
orquestra-sdk[ray]==0.47.0
orquestra-sdk[ray]==0.63.0
Example of using an unpublished version:
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/orquestra-sdk.git@v0.47.0
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/orquestra-sdk.git@v0.63.0#subdirectory=projects/orquestra-sdk
docker_tag:
type: string
description: |
Expand Down Expand Up @@ -55,8 +55,8 @@ jobs:
USER_TOKEN: ${{ secrets.PAGES_TOKEN }}
repository: ${{github.repository}}
ref: ${{ github.ref }}
path_to_dockerfile: './docker/cuda.Dockerfile'
docker_context_path: 'docker'
path_to_dockerfile: 'projects/orquestra-sdk/docker/cuda.Dockerfile'
docker_context_path: 'projects/orquestra-sdk/docker'
target_docker_repository: 'hub.stage.nexus.orquestra.io/zapatacomputing/orquestra-sdk-base'
github_sha: ${{ github.sha }}
build_number: ${{ github.run_number }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ on:
description: |
Orquestra SDK requirement to build the image with.
Example of using a published version of the SDK:
orquestra-sdk[ray]==0.47.0
orquestra-sdk[ray]==0.63.0
Example of using an unpublished version:
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/orquestra-sdk.git@v0.47.0
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/orquestra-sdk.git@v0.63.0#subdirectory=projects/orquestra-sdk
docker_tag:
type: string
description: |
Expand Down Expand Up @@ -53,8 +53,8 @@ jobs:
USER_TOKEN: ${{ secrets.PAGES_TOKEN }}
repository: ${{github.repository}}
ref: ${{ github.ref }}
path_to_dockerfile: 'docker/Dockerfile'
docker_context_path: 'docker'
path_to_dockerfile: 'projects/orquestra-sdk/docker/Dockerfile'
docker_context_path: 'projects/orquestra-sdk/docker'
target_docker_repository: 'hub.stage.nexus.orquestra.io/zapatacomputing/orquestra-sdk-base'
github_sha: ${{ github.sha }}
build_number: ${{ github.run_number }}
Expand Down

0 comments on commit 2e059f4

Please sign in to comment.