chore: make more add/sub test use variable num_blocks #1717
Conversation
tmontaigu
force-pushed
the
tm/test-num-blocks
branch
from
7209633
to
07a8653
Compare
| if modulus == 1 { | ||
| // Basically have one bit the sign bit can't really test | ||
| // Basically have one bit, the sign bit can't really test | ||
| continue; | ||
| } |
There was a problem hiding this comment.
this is even worse than that, we can't represent any value with such a modulus, the intended (?) test would be modulus <= 2 ?
Same everywhere
There was a problem hiding this comment.
Hum its not really clear when reading, but, the modulus here is actually the half_modulus since its obtained by doing modulus / 2, so its the modulus ignoring the sign bit
So if half_modulus == 1 then it means we have one bit which is the sign bit, as the 'value' bits only allow represent values with half_modulus == 1 so nothing
There was a problem hiding this comment.
ok got it, so the naming is a bit misleading
There was a problem hiding this comment.
are we able to test the minimum value then for a signed integer ?
i.e.
-2^b for some b ? as using the modulus on the abs value would limit us to -2^b + 1
There was a problem hiding this comment.
I will update the naming
tfhe/src/integer/server_key/radix_parallel/tests_signed/test_sub.rs
Outdated
Show resolved
Hide resolved
tmontaigu
force-pushed
the
tm/test-num-blocks
branch
from
07a8653
to
4b2c0ae
Compare
No description provided.