feat: implement 128bit fft #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-quinones
force-pushed
the
fft128
branch
from
89f2e8d
to
4e94b00
Compare
IceTDrinker
reviewed
Feb 14, 2023
sarah-quinones
force-pushed
the
fft128
branch
from
4e94b00
to
5efab2c
Compare
IceTDrinker
reviewed
Feb 17, 2023
sarah-quinones
force-pushed
the
fft128
branch
2 times, most recently
from
a96ee67
to
eccd8fa
Compare
tmontaigu
reviewed
Mar 1, 2023
IceTDrinker
reviewed
Mar 2, 2023
| } | ||
|
|
||
| #[inline(always)] | ||
| pub(crate) fn _mm256_quick_two_sum(simd: Avx, a: __m256d, b: __m256d) -> (__m256d, __m256d) { |
There was a problem hiding this comment.
as was discussed, move away from the intel intrisics notations
IceTDrinker
reviewed
Mar 2, 2023
|
|
||
| impl Avx { | ||
| #[inline(always)] | ||
| pub fn _mm256_add_estimate_f128_f128( |
There was a problem hiding this comment.
as was discussed bench and compare the non estimate versions to be able to have the choice potentially for intrisics to select between estimate and more precise implementations
IceTDrinker
reviewed
Mar 2, 2023
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
as discussed make sure all permutations are well tested
|
closed as superseded by #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.