Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple process queue not sharing #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lovemyliwu
Copy link

@lovemyliwu lovemyliwu commented Feb 28, 2018

when use handler in uwsgi --master the Queue and comsumer worker will be created by master process, but the producer is child process.

when use handler in celery worker, also have the problem above.

@zach-taylor
Copy link
Owner

Hey @lovemyliwu thanks for submitting this! Can you give me a little more information or background on the use-case for this change? Also is it possible to write a test to ensure we don't break multi-process queue functionality in the future?

@bdirito
Copy link

bdirito commented Aug 22, 2018

@zach-taylor If you use this splunk-handler inside a process that in turn spawns celery workers the celery workers will not be able to push logs to splunk (things like file handlers etc seem to work fine). This pr will allow all logs, both the root process & the celery workers, to be pushed to splunk.

@rh0dium
Copy link

rh0dium commented Jan 26, 2021

Is there any chance this can get merged in? I would really appreciate it.

@rh0dium
Copy link

rh0dium commented Jan 26, 2021

@zach-taylor a bit of background when you run this in production where you are running this behind uwsgi you won't see all of the messages. It's not clear why this is happening but we can correlate the N+1 threads are not capturing logs.

@JeffreyLMelvin
Copy link
Collaborator

@rh0dium or @lovemyliwu if this is still something that is desired, can one of you take on getting the PR updated with latest master and addressing any codeclimate issues? This does appear to be backwards compatible, and the PR conversations suggest general interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants