-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (optional) excalidraw custom asset path #1654
Merged
ggrossetie
merged 8 commits into
yuzutech:main
from
gerlingsm:feature/excalidraw_custom_asset_path
Oct 13, 2023
Merged
Add (optional) excalidraw custom asset path #1654
ggrossetie
merged 8 commits into
yuzutech:main
from
gerlingsm:feature/excalidraw_custom_asset_path
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Oct 2, 2023
…w.production.min.js
ggrossetie
reviewed
Oct 12, 2023
ggrossetie
reviewed
Oct 12, 2023
ggrossetie
reviewed
Oct 12, 2023
ggrossetie
reviewed
Oct 12, 2023
@gerlingsm It seems that using an empty value is the best of both worlds since it won't load assets from a CDN server side but it will use the CDN on client side (for fonts): <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 577 515" width="577" height="515">
<!-- svg-source:excalidraw -->
<defs>
<style class="style-fonts">
@font-face {
font-family: "Virgil";
src: url("https://unpkg.com/@excalidraw/[email protected]/dist/excalidraw-assets/Virgil.woff2");
}
@font-face {
font-family: "Cascadia";
src: url("https://unpkg.com/@excalidraw/[email protected]/dist/excalidraw-assets/Cascadia.woff2");
}
</style>
</defs> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pull request #1652 and fix issue #1651