Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2 bumpup to version 0.6.0, add themes, add options #1629

Merged
merged 6 commits into from
Aug 29, 2023
Merged

D2 bumpup to version 0.6.0, add themes, add options #1629

merged 6 commits into from
Aug 29, 2023

Conversation

vfosnar
Copy link
Contributor

@vfosnar vfosnar commented Aug 26, 2023

No description provided.

@ggrossetie
Copy link
Member

Thanks!
Could you please add a test case for each options added (in the following file):

kroki/ci/tests/smoke.js

Lines 42 to 44 in e9ef670

{ engine: 'd2', file: 'connections.d2', options: {}, outputFormat: ['svg'] },
{ engine: 'd2', file: 'connections.d2', options: { layout: 'elk' }, outputFormat: ['svg'] },
{ engine: 'd2', file: 'connections.d2', options: { sketch: 'true' }, outputFormat: ['svg'] },

@vfosnar
Copy link
Contributor Author

vfosnar commented Aug 28, 2023

Alright, tests passed!

@ggrossetie
Copy link
Member

All good, thank you 🤗

@ggrossetie ggrossetie merged commit 2be17fb into yuzutech:main Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants