Add a comment and move the global definition before loading excalidra…

…w.production.min.js
yuzutech · Oct 12, 2023 · ec65329 · ec65329
1 parent 5fe69e1
commit ec65329
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/excalidraw/src/worker.js b/excalidraw/src/worker.js
@@ -21,12 +21,13 @@ export default class Worker {
     try {
       await page.setViewport({ height: 800, width: 600 })
       await page.goto(this.pageUrl)
-      await page.addScriptTag({
-        path: `${path.join(__dirname, '..', 'assets', 'excalidraw', 'excalidraw.production.min.js')}`
-      });
       await page.addScriptTag({
         content: `window.EXCALIDRAW_ASSET_PATH="${this.assetPath}"`
-      });
+      })
+      // excalidraw.production.min.js is using the EXCALIDRAW_ASSET_PATH variable.
+      await page.addScriptTag({
+        path: `${path.join(__dirname, '..', 'assets', 'excalidraw', 'excalidraw.production.min.js')}`
+      })
       // QUESTION: should we reuse the page for performance reason ?
       return await page.evaluate(async (definition) => {
         const svgElement = await window.ExcalidrawLib.exportToSvg(JSON.parse(definition))