Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OTEL Exporter instead of Jaeger Exporter #18

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Use OTEL Exporter instead of Jaeger Exporter #18

merged 10 commits into from
Jul 2, 2024

Conversation

FlamingSaint
Copy link
Contributor

@FlamingSaint FlamingSaint commented Jun 29, 2024 •
edited by yurishkuro
Loading

Resolves jaegertracing/jaeger#5685

I have used the otel exporter instead of the jaeger exporter.
Also ran go get -d -t ./... and go mod tidy and fixed errors caused by it.

Use the OTEL_EXPORTER_OTLP_TRACES_ENDPOINT

export OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:14268/api/traces

yurishkuro
yurishkuro reviewed Jun 30, 2024
View reviewed changes
tracing/init.go Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jun 30, 2024
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
tracing/init.go Show resolved Hide resolved
model/service_instance.go Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jul 1, 2024
View reviewed changes
model/config.go Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jul 1, 2024
View reviewed changes
Copy link
Owner

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Did you test it with all-in-one, to see how the traces look?

@FlamingSaint
add suggestion
9354442 
Signed-off-by: FlamingSaint <[email protected]>
@FlamingSaint
Use otel env variables
d5c1a8b 
Signed-off-by: FlamingSaint <[email protected]>
yurishkuro
yurishkuro reviewed Jul 2, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jul 2, 2024
View reviewed changes
tracing/init.go Outdated Show resolved Hide resolved
@FlamingSaint
Add suggested changes
50b7e07 
Signed-off-by: FlamingSaint <[email protected]>
@yurishkuro
fix readme
08468aa 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 0f4a6f2 into yurishkuro:main Jul 2, 2024
2 checks passed
@FlamingSaint FlamingSaint deleted the fix-PR13 branch July 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement OTLP export in microsim
2 participants
@FlamingSaint @yurishkuro