Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Alert component #5

Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat: add Alert component #5

merged 1 commit into from
Apr 8, 2024

Conversation

Jandiasnow
Copy link
Member

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

add Alert component

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@yunti-bot
Copy link
Collaborator

๐Ÿ‘ @Jandiasnow


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Carrotzpc
Carrotzpc reviewed Apr 8, 2024
View reviewed changes
src/Alert/demos/Playground.tsx Outdated
const control: AlertProps | any = useControls(
{
message:
'Info Description Info Description Info Description Info Description Info Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info Description',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ๆ่ฟฐๅคช้šๆ„ไบ†๏ผŒๅฏไปฅๅŽป readme ้‡Œ้ขๆ‰พไบ›้•ฟ็š„ๅฅๅญ

src/Alert/demos/index.tsx Outdated
export default () => {
return (
<Alert
message="Info Description Info Description Info Description Info Description Info Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info DescriptionInfo Description Info Description Info Description Info Description"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ๅŒไธŠ

src/Alert/index.tsx Outdated

export interface CustomAlertProps {
/** position of icon */
iconPlacement?: 'top' | 'center';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconPlacement ๆ˜ฏๅฆๆœ‰ๅฟ…่ฆ๏ผŸ

@Carrotzpc Carrotzpc merged commit 2b8d823 into yuntijs:beta Apr 8, 2024
1 check passed
@yunti-bot
Copy link
Collaborator

โค๏ธ Great PR @Jandiasnow โค๏ธ


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ!

@yunti-bot
Copy link
Collaborator

๐ŸŽ‰ This PR is included in version 1.0.0-beta.9 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carrotzpc Carrotzpc Carrotzpc approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jandiasnow @yunti-bot @Carrotzpc