-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TubiTv] Extractor overhaul #32945
base: master
Are you sure you want to change the base?
[TubiTv] Extractor overhaul #32945
Conversation
* back-port login and extraction from yt-dlp * further extract uploader, age_limit, cast, categories, series
I believe most or all Tubi stuff is DRM:
|
Probably so, but the test videos here are examples of unprotected content. |
huh actually maybe I am wrong - this one uses DRM https://tubitv.com/movies/100003987/casino but if you disable Widevine it still works. OK never mind. this one use DRM: https://tubitv.com/movies/679215/the-three-stooges-meet-hercules and if you disable Widevine it wont play |
Maybe 100003987 has some, perhaps higher res, formats with DRM. The extractor is meant to ignore those if playable formats are found. Pls feel free to test this PR against it (requires US IP, or |
Tubi was in process of adding DRM when i was working on the extractor. dlp has checks to auto ignore drm material and hence we didn't bother much to explicitly handle it. Might want to check how dl treats drm content. |
Ive checked, its not. |
Boilerplate: own/yt-dlp code, bug fix/improvement
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR updates the extractor for tubitv.com and adds a series/season extractor.
The PR includes these features back-ported from yt-dlp:
TubiTvIE
: thx @shirt-dev, @chilinux, @bashonlyTubiTvShowIE
: thx @Ashish0804, @sqrtNOT, @bashonlyBreaking change:
TubiTvIE
no longer recognises the URL schemetubitv:{id}
; instead, usehttps://tubitv.com/tv-shows/{id}/
.Rationale for modifying
TubiTvShowIE
extraction tactic is here.