Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements were added to Utils.py, YoutubeDL.py and extractors/Youtube.py #32811

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jos3f19
Copy link

@Jos3f19 Jos3f19 commented Jun 12, 2024

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@Jos3f19
Copy link
Author

Jos3f19 commented Jun 12, 2024

Thank u

@dirkf
Copy link
Contributor

dirkf commented Jun 13, 2024

Thanks for your work.

These changes could be useful but to progress them please revise your contribution as follows:

  • split the changes into three separate PRs
  • for each one provide the rationale for the change (does it fix a problem, or is it just a better piece of code with the same behaviour ...)
  • ensure that there is a test showing that the new code is working
  • respect the coding conventions of yt-dl, eg, don't use f-strings.

@dirkf dirkf marked this pull request as draft June 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants