Inbound queue v2 #3
Conversation
Co-authored-by: Vincent Geddes <[email protected]>
…-sdk into outbound-queue-v2
Co-authored-by: Vincent Geddes <[email protected]>
yrong
force-pushed
the
inbound-queue-v2
branch
from
ca8e226
to
0e9cca0
Compare
| MAX_XCM_DECODE_DEPTH, | ||
| &mut message.xcm.as_ref(), | ||
| ) | ||
| .map_err(|_| Error::<T>::InvalidPayload)?; |
There was a problem hiding this comment.
We should not fail on Invalid xcm. We should rather build the xcm payload without appending anything. This will allow the assets to get trapped on assethub.
| &mut message.xcm.as_ref(), | ||
| ) | ||
| .map_err(|_| Error::<T>::InvalidPayload)?; | ||
| let xcm: Xcm<()> = versioned_xcm.try_into().map_err(|_| <Error<T>>::InvalidPayload)?; |
There was a problem hiding this comment.
Same here. Any issues parsing the XCM should result in assets getting trapped on Asset Hub.
| // Todo: Deposit fee(in Ether) to RewardLeger which should cover all of: | ||
| // T::RewardLeger::deposit(who, envelope.fee.into())?; | ||
| // a. The submit extrinsic cost on BH | ||
| // b. The delivery cost to AH |
There was a problem hiding this comment.
The xcm can be built here without the need for XCM v5 and we can re-do later when XCM v5 is ready.
You will need to parse the Assets in the ticket and build the following XCM to send to asset hub:
ReceiveTeleportedAsset(asset_hub_fees)
BuyExecution(fees: asset_hub_fees)
DescendOrigin(PalletInstance(inbound_queue_pallet_index))
UniversalOrigin(GlobalConsensus(network))
ReserveAssetDeposited(erc20_assets) // from assets that do not have tokenId
WithdrawAsset(pna_assets) // from assets that do have tokenId
DescendOrigin(msg_sender)
You can then append the xcm from the payload to this base xcm. If the xcm payload fails to be parsed, append nothing and send to asset hub anyway, this will cause the assets to get trapped on asset hub.
yrong
force-pushed
the
outbound-queue-v2
branch
from
fffd895
to
df137c0
Compare
No description provided.