Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the code for Stitching Video #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added the code for Stitching Video #31

wants to merge 3 commits into from

Conversation

yatharth9
Copy link

#26

@yatharth9
Copy link
Author

@yptheangel Resolved the Merge conflict. Kindly accept the PR.

@yptheangel
Copy link
Owner

@yatharth9 Are u attempting hacktoberfest using this PR? If yes, getting the hacktoberfest-accepted label is sufficient.

I wont merge this PR because it copies code from pyimagesearch without giving credit. Either u drop the dependencies or this will remain open

@yatharth9
Copy link
Author

I have mentioned it in the Readme. If it is not acceptable, I will submit code without such dependencies.

@yptheangel
Copy link
Owner

I have mentioned it in the Readme. If it is not acceptable, I will submit code without such dependencies.

@yatharth9 Yes, prefer without dependencies from pyimagesearch and imutils. Original cv2 functions will be preferred. Thanks. Can leave credits if you wish to if u use pyimagesearch as reference.

Anyways this PR is already labelled as hacktoberfest-accepted, it will still count as a contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yatharth9 @yptheangel